Uh oh!
There was an error while loading. Please reload this page.
Various return types and values consolidation - #19418
Merged
Merged
Conversation
alexandre-dauboisforce-pushed
the
cons-return-type-val
branch
from
August 8, 2025 13:13
3aee5cb to
25fb75aComparealexandre-daubois
marked this pull request as ready for review
August 8, 2025 13:20
Girgias
reviewed
Aug 8, 2025
Comment on lines
1207
to
1216
Member
There was a problem hiding this comment.
I would remove the {{{ marker all together if touching the function, and you can simplify this by just doing:
returnAvifInfoIdentifyStream(&avif_stream, php_avif_stream_read, php_avif_stream_skip) ==kAvifInfoOk;alexandre-dauboisforce-pushed
the
cons-return-type-val
branch
from
August 11, 2025 07:19
25fb75a to
c0f6e35CompareGirgias
approved these changes
Aug 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
TimWolla
commented
Aug 12, 2025
Member
Probably makes sense to fix this in bulk with Coccinelle. See torvalds/linux@46b5c9b as an example. |
alexandre-daubois
commented
Aug 12, 2025
MemberAuthor
Having a look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.