Skip to content

Remove references to ODBCVER and assume ODBC 3.x - #19453

Merged
NattyNarwhal merged 6 commits into
php:masterfrom
NattyNarwhal:remove-odbcver
Aug 12, 2025
Merged

Remove references to ODBCVER and assume ODBC 3.x#19453
NattyNarwhal merged 6 commits into
php:masterfrom
NattyNarwhal:remove-odbcver

Conversation

@NattyNarwhal

@NattyNarwhalNattyNarwhal commented Aug 11, 2025

Copy link
Copy Markdown
Member

See the approved RFC. This also includes (and obsoletes) GH-17556, since we can safely assume that these functions are available in ODBC 3.x.

@NattyNarwhal

NattyNarwhal commented Aug 12, 2025

Copy link
Copy Markdown
MemberAuthor

Just added UPGRADING comments and removed some useless defines on top of this, LMK if this still is good.

@TimWolla

TimWolla commented Aug 12, 2025

Copy link
Copy Markdown
Member

Just added UPGRADING comments

This should also go into NEWS (for Beta 2). As for this change, I'm not qualified to meaningfully review this, but I'm not seeing any obvious issues. As per https://externals.io/message/128453, I'm requesting a RM review.

@TimWolla
TimWolla requested a review from a teamAugust 12, 2025 16:46
NattyNarwhaland others added 5 commits August 12, 2025 15:18
@NattyNarwhal
Remove references to ODBCVER and assume ODBC 3.x
7b5799c
See https://wiki.php.net/rfc/deprecations_php_8_5#remove_support_for_older_odbc_versions
@cmb69@NattyNarwhal
Avoid calling deprecated ODBC functions
7432c18
`SQLGetConnectOption`, `SQLSetConnectOption` and `SQLSetStmtOption` are
deprecated, so if ODBC 3 is available, we use `SQLSetConnectAttr`,
`SQLGetConnectAttr`, and `SQLSetStmtAttr` instead.
(This is based on phpGH-17556, but just assumes ODBC 3.x.)
@NattyNarwhal
Remove wrappers for SQLColAttribute
c666884
We don't need to support the old way of doing it.
@NattyNarwhal
Just call SQLAllocHandle directly
2be7290
Again, no need for the version specific wrapper
@NattyNarwhal
Update NEWS for ODBCVER in beta2
3b00b61
DanielEScherzer
DanielEScherzer approved these changes Aug 12, 2025
View reviewed changes

@DanielEScherzerDanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks primarily like removal of a bunch of stuff and replacement of some macros with their definitions, looks good to me wearing the RM hat

@NattyNarwhal
NattyNarwhal merged commit 6004702 into php:masterAug 12, 2025
1 check passed
@DanielEScherzer

DanielEScherzer commented Aug 13, 2025

Copy link
Copy Markdown
Member

@NattyNarwhal the squashed commit message contains [skip ci] which is probably why CI was skipped for the overall commit in master

@NattyNarwhal

NattyNarwhal commented Aug 13, 2025

Copy link
Copy Markdown
MemberAuthor

Oops, I thought that only applied to the first line of the commit. I'll take care to remove these from future squashed commit messages.

@NattyNarwhalNattyNarwhal mentioned this pull request Aug 15, 2025
Closed
@jrfnljrfnl mentioned this pull request Sep 15, 2025
Open
70 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GirgiasGirgiasGirgias approved these changes
@DanielEScherzerDanielEScherzerDanielEScherzer approved these changes
@kocsismatekocsismateAwaiting requested review from kocsismatekocsismate is a code owner

Assignees

No one assigned

Labels

Category: Build SystemExtension: odbcRFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NattyNarwhal@TimWolla@DanielEScherzer@Girgias@cmb69