ext/standard: Deprecate $http_response_header

[Girgias]

RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_http_response_header_predefined_variable

[ndossche]

Hm, doesn't this need to be on the op array context instead? Otherwise we only warn once per compilation instead of once per file?

[Girgias]

I've added tests and it seems to work as I expect it

[ndossche]

Yeah okay I see I actually think I wanted to say "once per op_array", but if that's the intention that's fine I guess?

[Girgias]

But it seems to be once per op_array 🤔

[ndossche]

I'll check this again tomorrow when I'm more awake

[ndossche]

I see you reset the variable when a new op context starts, but they can be nested. So the following emits 2 deprecations even though it should only emit 1 (artificial example I know, but a simple one):

<?phpfunctionfoo() {
$http_response_header = "foo";
functionnested() {
echo$http_response_header;
}
echo$http_response_header;
}

You can remove the code from "nested" and it will still emit a deprecation that should not be happening.

[edorian]

RM approval: 👍

[ndossche]

I see you reset the variable when a new op context starts, but they can be nested. So the following emits 2 deprecations even though it should only emit 1 (artificial example I know, but a simple one):

<?phpfunctionfoo() {
$http_response_header = "foo";
functionnested() {
echo$http_response_header;
}
echo$http_response_header;
}

You can remove the code from "nested" and it will still emit a deprecation that should not be happening.

[Seldaek]

There seems to be an issue here @Girgias if you have a function taking $http_response_header as argument it warns about every usage..

See https://github.com/composer/composer/actions/runs/17278161064/job/49040109053 for the failures:

Error: PHP Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in src/Composer/Util/RemoteFilesystem.php on line 659
Error: PHP Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in src/Composer/Util/RemoteFilesystem.php on line 691
Error: PHP Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in src/Composer/Util/RemoteFilesystem.php on line 692
Error: PHP Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in src/Composer/Util/RemoteFilesystem.php on line 693
Error: PHP Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in src/Composer/Util/RemoteFilesystem.php on line 709

and composer/composer#12513 seems to fix it. Easy fix but I'd argue if you can make it not complain in those cases it would be nicer.

[Girgias]

Ah yes, that makes sense will fix it, can you open a dedicated issue for this? :)