Uh oh!
There was an error while loading. Please reload this page.
Deprecate disabling report_memleaks INI directive - #19481
Conversation
70f33af to
d6fdf2fCompareUh oh!
There was an error while loading. Please reload this page.
d6fdf2f to
6b546c7Comparereport_memleaks INI directivereport_memleaks INI directiveThere was a problem hiding this comment.
This formatting is inconsistent with the other deprecated options, please unify.
I also wonder if there still is value in having this option readily presented in the example INI files. It's deprecated and only affects a debug build. Perhaps we can just remove this entire block for improved DX? If we want to keep it, the INI should be commented, though (to make sure it uses the built-in default).
There was a problem hiding this comment.
I'd say it should be kept. It costs nothing and this will avoid making exceptions for certain settings. Maybe it could also be easier for maintainers when upmerging.
6b546c7 to
9a42d86CompareUh oh!
There was an error while loading. Please reload this page.
9a42d86 to
e3f4fefCompareUh oh!
There was an error while loading. Please reload this page.
e3f4fef to
6313179Compare6313179 to
a3b1595Compare
edorian
left a comment
There was a problem hiding this comment.
RM wise: 👍 to merge this during beta, once the technical details are approved by others
TimWolla
commented
Aug 16, 2025
Given the approvals and no other comments on #19481 (comment) I'm going ahead with merging. Should we decide to remove the INI from the example config, we can still do in a follow-up. |
Uh oh!
There was an error while loading. Please reload this page.
nicolas-grekas
commented
Aug 19, 2025
In order to minimize the noise-level of the deprecation, the deprecation should be triggered only in DEBUG builds. |
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_report_memleaks_ini_directive