Skip to content

Deprecate disabling report_memleaks INI directive - #19481

Merged
TimWolla merged 1 commit into
php:masterfrom
alexandre-daubois:report-memleaks-deprec
Aug 16, 2025
Merged

Deprecate disabling report_memleaks INI directive#19481
TimWolla merged 1 commit into
php:masterfrom
alexandre-daubois:report-memleaks-deprec

Conversation

@alexandre-daubois

@alexandre-dauboisalexandre-daubois commented Aug 14, 2025

Copy link
Copy Markdown
Member

@alexandre-daubois
alexandre-dauboisforce-pushed the report-memleaks-deprec branch 2 times, most recently from 70f33af to d6fdf2fCompareAugust 14, 2025 12:52
@alexandre-daubois
alexandre-daubois marked this pull request as ready for review August 14, 2025 13:25
Comment threadphp.ini-development Outdated
@alexandre-dauboisalexandre-daubois changed the title Deprecate report_memleaks INI directiveDeprecate disabling report_memleaks INI directiveAug 14, 2025
Comment threadphp.ini-development Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting is inconsistent with the other deprecated options, please unify.

I also wonder if there still is value in having this option readily presented in the example INI files. It's deprecated and only affects a debug build. Perhaps we can just remove this entire block for improved DX? If we want to keep it, the INI should be commented, though (to make sure it uses the built-in default).

@alexandre-dauboisalexandre-dauboisAug 14, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it should be kept. It costs nothing and this will avoid making exceptions for certain settings. Maybe it could also be easier for maintainers when upmerging.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tim

Comment threadphp.ini-development Outdated
Comment threadUPGRADING Outdated
@TimWolla
TimWolla requested review from a team and GirgiasAugust 14, 2025 19:39

@edorianedorian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM wise: 👍 to merge this during beta, once the technical details are approved by others

@TimWolla

Copy link
Copy Markdown
Member

Given the approvals and no other comments on #19481 (comment) I'm going ahead with merging. Should we decide to remove the INI from the example config, we can still do in a follow-up.

@TimWolla
TimWolla merged commit a84a82e into php:masterAug 16, 2025
9 checks passed
@nicolas-grekas

Copy link
Copy Markdown
Contributor

In order to minimize the noise-level of the deprecation, the deprecation should be triggered only in DEBUG builds.
On non -DEBUG builds, this is already a no-op, so there's no need to annoy the community with it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@alexandre-daubois@TimWolla@nicolas-grekas@bukka@edorian@ndossche@Girgias@DanielEScherzer