Skip to content

Add support for Uri\Rfc3986\Uri withers - #19636

Merged
kocsismate merged 8 commits into
php:masterfrom
kocsismate:ext-url8
Sep 8, 2025
Merged

Add support for Uri\Rfc3986\Uri withers#19636
kocsismate merged 8 commits into
php:masterfrom
kocsismate:ext-url8

Conversation

@kocsismate

Copy link
Copy Markdown
Member

No description provided.

Comment threadext/uri/uri_parser_rfc3986.c Outdated
Comment threadext/uri/uri_parser_rfc3986.c Outdated
Comment threadext/uri/uri_parser_rfc3986.c Outdated
Comment threadext/uri/uri_parser_rfc3986.c Outdated
@ndossche

Copy link
Copy Markdown
Member

It's probably best to commit the uriparser changes separately and base the PHP changes off on top of that.

@kocsismate

Copy link
Copy Markdown
MemberAuthor

It's probably best to commit the uriparser changes separately and base the PHP changes off on top of that.

Yes, sure! This PR in its current form is more like intended to test the setters. I'll create a separate one once the new uriparser release is done.

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to see #19636 (comment) changed, but I'm not seeing any bugs anymore.

Comment threadext/uri/uri_parser_rfc3986.c Outdated
Comment on lines 376 to 368

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could theoretically be adjusted to a switch() for consistency with the port, host, and userinfo setters (applies to all setters).

@TimWolla

Copy link
Copy Markdown
Member

Already requesting RM review, since I don't expect any more significant changes.

@TimWolla
TimWolla requested a review from a teamSeptember 5, 2025 21:14

@DanielEScherzerDanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM review - looks good, approved
Also did a minor technical review, some unused variables and parameters that could be removed

Comment threadext/uri/php_uri.c Outdated
Comment threadext/uri/uri_parser_rfc3986.c Outdated
Comment threadext/uri/tests/026.phpt Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contrary to the use of the comment above, this comment seems kinda useless: it throws me off because now I'm staring at what the difference is between the string and the comment but I don't see it ;)

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, you are right 😅 it's absolutely useless indeed

Comment threadext/uri/php_uri.c Outdated
Comment threadext/uri/uri_parser_rfc3986.c Outdated

@ndosschendossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kocsismate
kocsismate merged commit 4e8058e into php:masterSep 8, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kocsismate@ndossche@TimWolla@DanielEScherzer