Skip to content

zend_ast: Fix Closure scope for FCC in constant expression - #19639

Merged
TimWolla merged 3 commits into
php:masterfrom
TimWolla:gh19637-closure-scope
Sep 1, 2025
Merged

zend_ast: Fix Closure scope for FCC in constant expression#19639
TimWolla merged 3 commits into
php:masterfrom
TimWolla:gh19637-closure-scope

Conversation

@TimWolla

@TimWollaTimWolla commented Aug 30, 2025

Copy link
Copy Markdown
Member

Fixes#19637

iluuu1994
iluuu1994 approved these changes Aug 31, 2025
View reviewed changes

@iluuu1994iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. The class should be cached through the GET_CE_CACHE() mechanism.

Comment threadZend/zend_ast.c
@TimWolla

TimWolla commented Aug 31, 2025

Copy link
Copy Markdown
MemberAuthor

The class should be cached through the GET_CE_CACHE() mechanism.

Will look into that later.

@iluuu1994

iluuu1994 commented Aug 31, 2025

Copy link
Copy Markdown
Member

Will look into that later.

I was just confirming this should already work (stupid ambiguous English language 😄).

@TimWolla
TimWolla merged commit c93b467 into php:masterSep 1, 2025
9 checks passed
@TimWolla
TimWolla deleted the gh19637-closure-scope branch September 1, 2025 19:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994iluuu1994iluuu1994 approved these changes
@edorianedorianedorian approved these changes

Assignees

No one assigned

Labels

Category: Engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Closure scope for FCC in constant expression

3 participants

@TimWolla@iluuu1994@edorian