Uh oh!
There was an error while loading. Please reload this page.
ext/ldap: [RFC] Deprecate build with Oracle Instance Client version. - #19809
Conversation
devnexen
commented
Sep 12, 2025
Do not know if I need any more warning in other places. There does not seem any CI for using Oracle Instant Client. |
There was a problem hiding this comment.
I guess you should consistently use () when referring to a function name. You did so on line 976 but not here.
There was a problem hiding this comment.
Also this should use the #[\Deprecated] attribute in the stub instead of triggering this in C.
4975330 to
5132197Compare6cd78fc to
3b22db1Compare
DanielEScherzer
left a comment
There was a problem hiding this comment.
RM review, left some notes inline but this is approved, technical review not performed
There was a problem hiding this comment.
| ldap_connect with wallet support | |
| ldap_connect_wallet | |
| ldap_connect() with wallet support | |
| ldap_connect_wallet() |
There was a problem hiding this comment.
should we include the version of the deprecation here? I'm not familiar with the SOP for deprecations in the build configurations so if that isn't standard no need to include it
There was a problem hiding this comment.
No that s a good point I ll add the version
3b22db1 to
3efb7f2CompareUh oh!
There was an error while loading. Please reload this page.
No description provided.