Uh oh!
There was an error while loading. Please reload this page.
zend_builtin_functions: Do not allocate to store name of FLF when fetching backtrace - #19842
Merged
Merged
Conversation
TimWolla added a commit
to TimWolla/php-src
that referenced
this pull request
Sep 15, 2025
While investigating php#19842 I was wondering why non-interned string didn't cause troubles, until I realized it was the value instead of the key. Nevertheless it appears useful to check that the key is actually interned as claimed by the caller to prevent hard-to-find bugs.
iluuu1994
approved these changes
Sep 15, 2025
iluuu1994
left a comment
Member
There was a problem hiding this comment.
LGTM, not sure why I had created a temporary string.
Uh oh!
There was an error while loading. Please reload this page.
TimWolla added a commit
that referenced
this pull request
Sep 16, 2025
* zend_hash: Assert that the `interned` parameter is not a lie While investigating #19842 I was wondering why non-interned string didn't cause troubles, until I realized it was the value instead of the key. Nevertheless it appears useful to check that the key is actually interned as claimed by the caller to prevent hard-to-find bugs. * zend_hash: Rename `interned` parameter name to `key_guaranteed_interned`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.