Skip to content

Revert deprecation of __sleep and __wakeup - #19966

Merged
bukka merged 3 commits into
php:PHP-8.5from
nicolas-grekas:revert-sleep-wakeup-deprec
Oct 6, 2025
Merged

Revert deprecation of __sleep and __wakeup#19966
bukka merged 3 commits into
php:PHP-8.5from
nicolas-grekas:revert-sleep-wakeup-deprec

Conversation

@nicolas-grekas

@nicolas-grekasnicolas-grekas commented Sep 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Without precluding the result of the vote at https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup

I'm trying to help PHP 8.5 RMs get ready for RC2, as advised in this message:
https://externals.io/message/128643#128659

This PR reverts the commits on the topic, related to PRs #19682 and #19435
It also reverts #19827

Reviews welcome to ensure this can be merged on Oct. 4th if the vote passes.

/cc @DanielEScherzer@edorian

@nicolas-grekas
nicolas-grekas changed the base branch from master to PHP-8.5September 25, 2025 18:23
@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch 2 times, most recently from 30913e3 to 6f3c8f2CompareSeptember 25, 2025 18:27
@nicolas-grekas

nicolas-grekas commented Sep 25, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm wondering if it's worth reverting #19827 given that the affected classes already have __[un]serialize hooks since a few years now (since PHP 8.2).

TimWolla
TimWolla reviewed Sep 25, 2025
View reviewed changes
Comment threadNEWS
TimWolla
TimWolla reviewed Sep 25, 2025
View reviewed changes
Comment threadUPGRADING
@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch from a7d54d1 to 0375921CompareSeptember 26, 2025 07:23
@nicolas-grekas

nicolas-grekas commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, I removed the commits that reverted NEWS updates and also removed the revert of #19827, which can and should be kept to me.
I also added a commit to update the NEWS/UPGRADING files to mention the soft-deprecation.

@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch from 0375921 to ea69ff6CompareSeptember 26, 2025 07:26
TimWolla
TimWolla reviewed Sep 26, 2025
View reviewed changes
Comment threadUPGRADING Outdated
@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch from ea69ff6 to 32ffdd0CompareSeptember 26, 2025 07:50
@xabbuhxabbuh mentioned this pull request Sep 29, 2025
Merged
Girgias
Girgias reviewed Sep 30, 2025
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but LGTM otherwise.

Comment threadext/session/tests/bug53141.phpt
Comment threadext/standard/tests/serialize/001.phpt Outdated
@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch from 32ffdd0 to 0b844d4CompareSeptember 30, 2025 13:56
ndossche
ndossche approved these changes Sep 30, 2025
View reviewed changes

@ndosschendossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a technical PoV

theodorejb
theodorejb reviewed Oct 1, 2025
View reviewed changes
Comment threadext/session/tests/bug53141.phpt Outdated
edorian
edorian approved these changes Oct 2, 2025
View reviewed changes

@edorianedorian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the, likely, condition that the RFC passes: 👍 RM wise.

Thank you for getting everything ready, making it easy to stay within the plan made to get this sorted cleanly. Much appreciated.

@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch from 0b844d4 to e5ae1d8CompareOctober 2, 2025 11:09
@nicolas-grekas
nicolas-grekasforce-pushed the revert-sleep-wakeup-deprec branch from e5ae1d8 to f58da91CompareOctober 6, 2025 06:47
@bukka
bukka merged commit fc35396 into php:PHP-8.5Oct 6, 2025
9 checks passed
@DanielEScherzer

DanielEScherzer commented Oct 6, 2025

Copy link
Copy Markdown
Member

I was planning to review this today and then merge it, sorry for the delay - looks good to me and I guess has already been merged

@jnoordsijjnoordsij mentioned this pull request Oct 7, 2025
Closed
@xabbuhxabbuh mentioned this pull request Oct 7, 2025
Closed
@kubawerloskubawerlos mentioned this pull request Oct 16, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWollaTimWollaTimWolla left review comments
@GirgiasGirgiasGirgias left review comments
@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
@edorianedorianedorian approved these changes
@ndosschendosschendossche approved these changes
@bukkabukkaAwaiting requested review from bukkabukka is a code owner
@kamil-tekielakamil-tekielaAwaiting requested review from kamil-tekielakamil-tekiela is a code owner
@SakiTakamachiSakiTakamachiAwaiting requested review from SakiTakamachiSakiTakamachi is a code owner
@derickrderickrAwaiting requested review from derickrderickr is a code owner
@kocsismatekocsismateAwaiting requested review from kocsismate
+1 more reviewer
@theodorejbtheodorejbtheodorejb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Category: EngineExtension: dateExtension: domExtension: pdo_mysqlExtension: pharExtension: sessionExtension: splExtension: standardRFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nicolas-grekas@DanielEScherzer@TimWolla@edorian@theodorejb@ndossche@Girgias@bukka