Uh oh!
There was an error while loading. Please reload this page.
Intl: Remove unumberrangeformatter.h include in IntlNumberRangeFormatter - #19980
Merged
Merged
Conversation
devnexen
approved these changes
Sep 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
BogdanUngureanu
commented
Sep 27, 2025
ContributorAuthor
Thanks @devnexen for the fast approval & merge. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't use it in the class implementation and it's causing a build failure on systems with ICU 67, this PR removes the include.
The problem is that IntlNumberRangeFormatter should work with ICU 63 and up, however, the C equivalent is available from ICU 68.
see #19232 (comment)
Tested with this container on ICU 67.1: https://gist.github.com/BogdanUngureanu/943f8ffdf8dfc84123aa9c53bc995a7a