Uh oh!
There was an error while loading. Please reload this page.
Fix GH-20603 issue on windows 32 bits. - #20634
Closed
devnexen wants to merge 2 commits into
Closed
Conversation
the timeout needed to be unsigned.
ndossche
reviewed
Dec 2, 2025
devnexen
commented
Dec 2, 2025
MemberAuthor
ah yes zend_ulong is uint32_t in 32 bits case.. |
ndossche
approved these changes
Dec 3, 2025
ndossche
left a comment
Member
There was a problem hiding this comment.
This looks right, although I wonder why you even need the double case and double division instead of using integer division?
edorian pushed a commit
that referenced
this pull request
Dec 9, 2025
the timeout needed to be unsigned. closeGH-20634
bukka pushed a commit
that referenced
this pull request
Dec 12, 2025
bukka pushed a commit
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the timeout needed to be unsigned.