ext/standard: Refactor scanf - #20682

Draft

Girgias wants to merge 31 commits into

php:masterfrom

Girgias:scanf-issues

Commits on Dec 11, 2025

ext/standard: Delete fscanf test cases that write arrays to file via fprintf
Girgias
committed
570c2eb
ext/standard: Delete fscanf test cases that write resources to file via fprintf
Girgias
committed
a7dff9c
ext/standard: Delete fscanf test cases that write objects to file via fprintf
Girgias
committed
ec67bbd
ext/standard: Delete fscanf test cases that write bools to file via fprintf
Girgias
committed
e0378f6
ext/standard: Remove invalid specifier tests for fscanf
Girgias
committed
2f13db4
ext/standard: Move fscanf tests to subfolder
Girgias
committed
3889123
ext/standard: Refactor fscanf test using strings
Girgias
committed
58d7495
ext/standard: Move sscanf tests to subfolder
Girgias
committed
a1e9a9a
ext/standard: Add some sscanf tests
Girgias
committed
6c16086
ext/standard/scanf.h: use 0 instead of SUCCESS to define scan success value
Girgias
committed
d80fff2
ext/standard/scanf: drop checking of php_sscanf_internal as it always throws on error
Girgias
committed
878fb75
ext/standard/scanf: use uint32_t type instead of int for argCount argument
Girgias
committed
86a447d
ext/standard/scanf: use zend_ulong type instead of int for objIndex variable
Girgias
committed
2e5d64a
ext/standard/scanf: make ValidateFormat function private
Girgias
committed
acf692c
ext/standard/scanf: remove varStart parameter which is always 0
Girgias
committed
41d4456
ext/standard/scanf: add assignToVariables variable and parameter
Girgias
committed
45ba2fb
ext/standard/scanf: use type uint32_t instead of int for totalSubs parameter of ValidateFormat()
Girgias
committed
fe61460
ext/standard/scanf: use type bool instead of int for variables in ValidateFormat()
Girgias
committed
a431568
ext/standard/scanf: use type uint32_t instead of int for variables in ValidateFormat()
Girgias
committed
9003847
ext/standard/scanf: use memset to initialize array of 0s
Girgias
committed
57025bd
ext/standard/scanf: remove unused includes
Girgias
committed
6772c8f
ext/standard/scanf: refactor CharInSet()
Girgias
committed
8eea8e6
ext/standard/scanf: add const qualifiers in BuildCharSet() and ValidateFormat()
Girgias
committed
9209efd
unsigned vars
Girgias
committed
b75745f
ext/standard/scanf: add const qualifiers for format param
Girgias
committed
a9a9401
ext/standard/scanf: add const qualifiers for string param
Girgias
committed
89ac4f5
ext/standard/scanf: convert format param to zend_string
Girgias
committed
a4cdd52
ext/standard/scanf: add format_arg_num param
Girgias
committed
50a41d4
Refactor string format parsing
Girgias
committed
3182b2e
ext/standard: pass string length
Girgias
committed
4730501
ext/standard/scanf.c: Refactor parsing and scanning
Girgias
committed
ab81474

Navigation Menu

Uh oh!

ext/standard: Refactor scanf - #20682

ext/standard: Refactor scanf#20682
Girgias wants to merge 31 commits into
php:masterfrom
Girgias:scanf-issues

Commits on Dec 11, 2025

ext/standard: Delete fscanf test cases that write arrays to file via fprintf

ext/standard: Delete fscanf test cases that write resources to file via fprintf

ext/standard: Delete fscanf test cases that write objects to file via fprintf

ext/standard: Delete fscanf test cases that write bools to file via fprintf

ext/standard: Remove invalid specifier tests for fscanf

ext/standard: Move fscanf tests to subfolder

ext/standard: Refactor fscanf test using strings

ext/standard: Move sscanf tests to subfolder

ext/standard: Add some sscanf tests

ext/standard/scanf.h: use 0 instead of SUCCESS to define scan success value

ext/standard/scanf: drop checking of php_sscanf_internal as it always throws on error

ext/standard/scanf: use uint32_t type instead of int for argCount argument

ext/standard/scanf: use zend_ulong type instead of int for objIndex variable

ext/standard/scanf: make ValidateFormat function private

ext/standard/scanf: remove varStart parameter which is always 0

ext/standard/scanf: add assignToVariables variable and parameter

ext/standard/scanf: use type uint32_t instead of int for totalSubs parameter of ValidateFormat()

ext/standard/scanf: use type bool instead of int for variables in ValidateFormat()

ext/standard/scanf: use type uint32_t instead of int for variables in ValidateFormat()

ext/standard/scanf: use memset to initialize array of 0s

ext/standard/scanf: remove unused includes

ext/standard/scanf: refactor CharInSet()

ext/standard/scanf: add const qualifiers in BuildCharSet() and ValidateFormat()

unsigned vars

ext/standard/scanf: add const qualifiers for format param

ext/standard/scanf: add const qualifiers for string param

ext/standard/scanf: convert format param to zend_string

ext/standard/scanf: add format_arg_num param

Refactor string format parsing

ext/standard: pass string length

ext/standard/scanf.c: Refactor parsing and scanning