Uh oh!
There was an error while loading. Please reload this page.
fix duplicated words typos in php codebases - #20800
Merged
Merged
Conversation
LamentXU123
requested review from
TimWolla, bukka, derickr, devnexen, kocsismate and zeriyoshi
as code ownersDecember 30, 2025 00:54
kocsismate
commented
Dec 30, 2025
Member
Some of these files are bundled libraries (e.g. timelib, uriparser), therefore the fixes should go upstream. And this is why the "verify bundled files" job fails, because those files shouldn't be modified in php-src. |
MemberAuthor
Fixes concerning upstream programs are removed. |
iluuu1994
commented
Dec 30, 2025
Member
date/lib and ext/uri/uriparser should still be reverted. |
Uh oh!
There was an error while loading. Please reload this page.
iluuu1994
commented
Dec 31, 2025
Member
Thank you @LamentXU123! |
TimWolla added a commit
to TimWolla/uriparser
that referenced
this pull request
Jan 1, 2026
Originally reported in php/php-src#20800. Co-authored-by: lamentxu <1372449351@qq.com>
TimWolla
commented
Jan 1, 2026
Member
Upstream patch for uriparser in uriparser/uriparser#290. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I am reading the codebases I found those typos have a relatively high occurrence.
This PR fixes them all. (I don't think we need an issue or emails for this, so I open this PR directly)