Fix getPartsIterator stub

[VincentLanglet]

Hi,

I'm not familiar with php codebase but I feel like there is an error in definition of getPartsIterator

• In the stub the arg is defined as a string
• Looking at the constant it's defined as an int
  

  php-src/ext/intl/breakiterator/breakiterator_iterators.stub.php

  Line 9 in 65b4073

  publicconstintKEY_SEQUENTIAL = UNKNOWN;

Also, I dunno if I have to update this code too

php-src/ext/intl/breakiterator/breakiterator_arginfo.h

Line 41 in 65b4073

ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, type, IS_STRING, 0, "IntlPartsIterator::KEY_SEQUENTIAL")

See the inconsistency in the doc
https://www.php.net/manual/en/class.intlpartsiterator.php
https://www.php.net/manual/en/intlbreakiterator.getpartsiterator.php

[devnexen]

Yes the actual method takes a zend_long so in the stub it should be an int argument indeed. @kocsismate wdyt ?

[iluuu1994]

Same applies here, this is LSP breaking, so I don't think this should target 8.4, but master.

[VincentLanglet]

Same applies here, this is LSP breaking, so I don't think this should target 8.4, but master.

But in this case, if someone was extending this method, wouldn't already he have an issue with the default value ?
https://onlinephp.io/c/9e9ca8

[iluuu1994]

Not if they don't use strict_types.

[VincentLanglet]

@iluuu1994 I updated the branch/PR to target master.

[kocsismate]

Thanks for the fix!