Uh oh!
There was an error while loading. Please reload this page.
ext/session: add recursive session cleanup for dirname > 0 - #21491
Conversation
Girgias
left a comment
There was a problem hiding this comment.
I don't really understand why we need to loops that are basically identical? Also I'd prefer if those new GC tests are in a subfolder (maybe even a mod_files subfolder)
jorgsowa
commented
Mar 24, 2026
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
devnexen
commented
Apr 8, 2026
I had a good look, it looks correct ; just need to address gina's comment. |
Uh oh!
There was an error while loading. Please reload this page.
When
dirnameis bigger than 0, there is no automatic cleanup of old sessions. I think it's oversight and shouldn't work like this. If the performance is the issue then lower GC probability should be set instead ignoring cleanup.This is not security issue, because documentation clearly state the current behavior, but still should work differently from the first place.