Skip to content

ext/snmp: rename argument number variables - #21723

Merged
Girgias merged 3 commits into
php:masterfrom
prateekbhujel:prateekbhujel/snmp-meaningful-arg-names
Apr 13, 2026
Merged

ext/snmp: rename argument number variables#21723
Girgias merged 3 commits into
php:masterfrom
prateekbhujel:prateekbhujel/snmp-meaningful-arg-names

Conversation

@prateekbhujel

@prateekbhujelprateekbhujel commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

This is a readability-only follow-up to #21319.

It renames the internal argument-number variables added for error reporting so they describe what they represent more clearly, and replaces the inline SNMP::setSecurity() comment with named locals at the call site.

No behavior changes are intended.

Testing:

  • git diff --check

@prateekbhujelprateekbhujel mentioned this pull request Apr 11, 2026
Merged
Girgias
Girgias requested changes Apr 13, 2026
View reviewed changes
Comment threadext/snmp/snmp.c Outdated
Comment threadext/snmp/snmp.c Outdated
Comment threadext/snmp/snmp.c Outdated
Girgias
Girgias reviewed Apr 13, 2026
View reviewed changes
Comment threadext/snmp/snmp.c Outdated
Girgias
Girgias approved these changes Apr 13, 2026
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let CI run and then merge :)

@Girgias
Girgias merged commit d0167e7 into php:masterApr 13, 2026
19 checks passed
@prateekbhujel
prateekbhujel deleted the prateekbhujel/snmp-meaningful-arg-names branch April 13, 2026 11:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GirgiasGirgiasGirgias approved these changes

Assignees

No one assigned

Labels

Extension: snmp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prateekbhujel@Girgias