Skip to content

Add zend_argument_type_error_ex, zend_argument_error_ex - #21829

Merged
TimWolla merged 6 commits into
php:masterfrom
arnaud-lb:zend-error-ex
Jul 16, 2026
Merged

Add zend_argument_type_error_ex, zend_argument_error_ex#21829
TimWolla merged 6 commits into
php:masterfrom
arnaud-lb:zend-error-ex

Conversation

@arnaud-lb

@arnaud-lbarnaud-lb commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown
Member

These variants take the function as parameter instead of inferring it from the call stack. This is useful in ZEND_TYPE_ASSERT, and will be used in PFA impl.

@arnaud-lb
arnaud-lb marked this pull request as ready for review April 22, 2026 09:37
@arnaud-lb
arnaud-lb requested a review from dstogov as a code ownerApril 22, 2026 09:37
@arnaud-lb
arnaud-lb requested a review from TimWollaApril 22, 2026 13:35
Girgias
Girgias approved these changes Apr 22, 2026
View reviewed changes

@GirgiasGirgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a lot of sense :)

TimWolla
TimWolla approved these changes Apr 22, 2026
View reviewed changes

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way LGTM, consider adding the new functions to UPGRADING.INTERNALS with a short note.

Comment threadZend/zend_API.c
@arnaud-lb
arnaud-lb requested a review from bukka as a code ownerMay 6, 2026 09:27
@arnaud-lb
arnaud-lb requested a review from TimWollaMay 6, 2026 09:29
TimWolla
TimWolla reviewed May 6, 2026
View reviewed changes
Comment threadZend/zend_API.c Outdated
Comment threadext/openssl/openssl.c Outdated
Comment threadZend/zend_API.c Outdated
Comment threadZend/zend_API.c Outdated
Comment threadZend/zend_API.c Outdated
Comment threadZend/zend_API.c Outdated
Comment threadZend/zend_API.c Outdated
Comment threadZend/zend_API.c Outdated
Comment threadZend/zend_API.h Outdated
TimWolla
TimWolla approved these changes Jul 16, 2026
View reviewed changes

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed API LGTM. Don't forget to mention the change in UPGRADING.INTERNALS.

Comment threadZend/zend_API.h
Comment threadext/openssl/openssl.c Outdated
@arnaud-lb
Add zend_argument_type_error_ex, zend_argument_error_ex
a5beccf
These variants take the function as parameter instead of infering it from the
call stack. This is useful in ZEND_TYPE_ASSERT, and will be used in PFA impl.
@arnaud-lb
Reduce API surface
e18edf9
@arnaud-lb
Consistent argument order
2422f15
@TimWolla
TimWolla merged commit e60d756 into php:masterJul 16, 2026
17 of 18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWollaTimWollaTimWolla approved these changes
@GirgiasGirgiasGirgias approved these changes
@dstogovdstogovAwaiting requested review from dstogovdstogov is a code owner
@bukkabukkaAwaiting requested review from bukkabukka is a code owner

Assignees

No one assigned

Labels

ABI breakCategory: EngineExtension: openssl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnaud-lb@TimWolla@Girgias