Uh oh!
There was an error while loading. Please reload this page.
Zlib: Fix the bug when zval_get_long silently cast several options into long in deflate_init - #21860
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Girgias
reviewed
Apr 27, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| return true; | ||
| } | ||
| ZVAL_DEINDIRECT(option_buffer); |
Member
There was a problem hiding this comment.
Blerg, we need to deindirect because it uses the shitty H ZPP specifier...
MemberAuthor
There was a problem hiding this comment.
Yeah... ㄟ( ▔, ▔ )ㄏ
I think it would be good to add a comment here... Anyway, thanks for advice ;)
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Girgias
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened #21841 yesterday to fix the case in one option
strategyand after a closer look this morning I realized almost every options in this function has the same problem. So this follow-up PR fix them all. (I will take a look of similar occasions in the future :) ).plus: to make things easy I write a helper function to throw errors