Skip to content

Implement "Followup improvements for ext/uri" RFC - Host type detection - #22100

Merged
kocsismate merged 3 commits into
php:masterfrom
kocsismate:uri-followup2
May 24, 2026
Merged

Implement "Followup improvements for ext/uri" RFC - Host type detection#22100
kocsismate merged 3 commits into
php:masterfrom
kocsismate:uri-followup2

Conversation

@kocsismate

@kocsismatekocsismate commented May 20, 2026

Copy link
Copy Markdown
Member

@kocsismate
kocsismate requested a review from ndosscheMay 20, 2026 20:13
@kocsismate
kocsismate requested a review from TimWolla as a code ownerMay 20, 2026 20:13
@kocsismatekocsismate changed the title mplement "Followup improvements for ext/uri" RFC - Host type detectionImplement "Followup improvements for ext/uri" RFC - Host type detectionMay 20, 2026
TimWolla
TimWolla approved these changes May 24, 2026
View reviewed changes

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the one remark (and missing NEWS / UPGRADING).

Comment threadext/uri/tests/rfc3986/getters/host_type_success_none.phpt Outdated
@kocsismate
kocsismate merged commit d8a5aec into php:masterMay 24, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWollaTimWollaTimWolla approved these changes
@ndosschendosscheAwaiting requested review from ndossche

Assignees

No one assigned

Labels

ABI breakExtension: uri

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kocsismate@TimWolla