Skip to content

ini_get_all(): Add builtin_default_value column - #22134

Merged
TimWolla merged 5 commits into
php:masterfrom
sebastianbergmann:issue-22133/compiled-in-default-value-ini-setting
May 24, 2026
Merged

ini_get_all(): Add builtin_default_value column#22134
TimWolla merged 5 commits into
php:masterfrom
sebastianbergmann:issue-22133/compiled-in-default-value-ini-setting

Conversation

@sebastianbergmann

@sebastianbergmannsebastianbergmann commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This implements an additional column for ini_get_all() with the compiled-in default value of a PHP INI setting as suggested in #22133.

@sebastianbergmannsebastianbergmann mentioned this pull request May 23, 2026
Draft
mvorisek
mvorisek reviewed May 23, 2026
View reviewed changes
Comment threadext/standard/basic_functions.c Outdated
@sebastianbergmannsebastianbergmann changed the title Closes #22133Additional column for ini_get_all() with the compiled-in default value of a PHP INI settingMay 23, 2026
bukka
bukka approved these changes May 23, 2026
View reviewed changes

@bukkabukka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's give it a little bit of time for others to check

@edorian
edorian requested a review from TimWollaMay 23, 2026 09:30
TimWolla
TimWolla reviewed May 23, 2026
View reviewed changes

@TimWollaTimWolla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM, I just have opinions about the color of the bikeshed.

Comment threadext/standard/basic_functions.c Outdated
Comment threadUPGRADING Outdated
@sebastianbergmannsebastianbergmann changed the title Additional column for ini_get_all() with the compiled-in default value of a PHP INI settingAdditional column for ini_get_all() with the built-in default value of a PHP INI settingMay 23, 2026
@TimWollaTimWolla linked an issue May 23, 2026 that may be closed by this pull request
API to obtain the built-in default value of a PHP INI setting #22133
Closed
@TimWollaTimWolla changed the title Additional column for ini_get_all() with the built-in default value of a PHP INI settingini_get_all(): Add builtin_default_value columnMay 23, 2026
DanielEScherzer
DanielEScherzer approved these changes May 24, 2026
View reviewed changes

@DanielEScherzerDanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I think this is small enough to not require an RFC

This was referenced May 24, 2026
Closed
Merged
@TimWolla
TimWolla merged commit f58b95e into php:masterMay 24, 2026
19 checks passed
@sebastianbergmannsebastianbergmann mentioned this pull request May 25, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukkabukkabukka approved these changes
@TimWollaTimWollaTimWolla approved these changes
@GirgiasGirgiasGirgias approved these changes
@DanielEScherzerDanielEScherzerDanielEScherzer approved these changes
+1 more reviewer
@mvorisekmvorisekmvorisek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Category: ConfigurationExtension: standardFeature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API to obtain the built-in default value of a PHP INI setting

6 participants

@sebastianbergmann@bukka@TimWolla@mvorisek@Girgias@DanielEScherzer