ext/uri: Fix static build on Windows by defining LEXBOR_STATIC

[luthermonson]

Summary

ext/uri is always built statically and pulls in the bundled lexbor headers via /I ext/lexbor. On Windows, lexbor's LXB_API macro defaults to __declspec(dllimport) when LEXBOR_STATIC isn't defined. As a result, when PHP itself is linked statically (no DLL) on Windows, every lxb_* symbol referenced from ext/uri fails to resolve:

libphp.lib(php_uri.obj) : error LNK2019: unresolved external symbol
__imp_lxb_url_parse referenced in function ...
... (one LNK2019 per lxb_* function reachable from ext/uri) ...

[TimWolla]

I know nothing about Windows. Should / Must this be fixed in ext/lexbor instead?

[luthermonson]

I think your instinct is correct, i"m running a test right now with a change to lexbor and will report back

[luthermonson]

@TimWolla thanks for the insight , the change now in lexbor had the same results as doing the define in config.w32 and i was able to get clean static builds on all platforms.

[shivammathur]

Please limit LEXBOR_STATIC to CFLAGS_URI instead of defining it globally.

[TimWolla]

Please limit LEXBOR_STATIC to CFLAGS_URI instead of defining it globally.

ext/lexbor is always statically built into PHP and is intended to be reusable across different extensions (e.g. ext/uri, ext/dom). Should the define actually be limited to CFLAGS_URI then?

[shivammathur]

@TimWolla Yes, that is correct, my concern is in case dom is built as a shared extension (See GH-21911), ext/dom/config.w32 does not set LEXBOR_STATIC and this would set it.

[luthermonson]

so go back to the ext/dom/config.w32 fix with adding /D LEXBOR_STATIC? arent we still worred about that being overwritten?

[shivammathur]

@luthermonson

LEXBOR_STATIC should be set for extensions that are built statically like static dom and uri. For a shared extension LXB_API being __declspec(dllimport) is correct.

Adding /D LEXBOR_STATIC in ext/uri/config.w32 should fix the LNK2019 error without changing the linkage semantics for shared dom.

ADD_FLAG("CFLAGS_URI","/D LEXBOR_STATIC");

[luthermonson]

Done, I'm running my builds to confirm this fixed it but I trust your judgment. Thank you for the help to get through this

[TimWolla]

like static dom

Okay, I'm seeing it's already done for dom:

php-src/ext/dom/config.w32

Line 29 in 9596ab1

ADD_FLAG("CFLAGS_DOM","/D LIBXML_STATIC /D LEXBOR_STATIC ");

[luthermonson]

Confirmed by the way, my static builds all worked with the change in uri