Uh oh!
There was an error while loading. Please reload this page.
pdo_pgsql: preserve the pending exception when a COPY row fails to convert - #22384
Closed
iliaal wants to merge 1 commit into
Closed
pdo_pgsql: preserve the pending exception when a COPY row fails to convert#22384iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
devnexen
commented
Jun 21, 2026
Member
seems PHP-8.5 has the same issue. |
iliaalforce-pushed
the
pdo-pgsql-copy-errorinfo
branch
from
June 21, 2026 16:05
bf3be23 to
8f802aeCompareiliaal
commented
Jun 21, 2026
ContributorAuthor
Right, 8.5 has the identical block; 8.4 already returns through the exception so it's unaffected. Retargeted to PHP-8.5. |
| $db->exec('CREATE TABLE test_copy_non_stringable (v text)'); | ||
| try { | ||
| $db->pgsqlCopyFromArray('test_copy_non_stringable', [new stdClass()]); |
Member
There was a problem hiding this comment.
seems to me the recommended method is fixed too right ? might be nice to test it.
ContributorAuthor
There was a problem hiding this comment.
Right, both route through pgsqlCopyFromArray_internal. Added a Pdo\Pgsql::copyFromArray() case; same HY000 without the patch, clean with it.
…nvert pgsqlCopyFromArray() feeds each row through try_convert_to_string(). A non-stringable row throws a TypeError, but both the array and iterator branches then called pdo_pgsql_error() and recorded a fabricated PGRES_FATAL_ERROR, leaving PDO::errorInfo() reporting "HY000" for what is a client-side type error. Return through the pending exception instead of overwriting the driver error state.
iliaalforce-pushed
the
pdo-pgsql-copy-errorinfo
branch
from
June 21, 2026 18:23
8f802ae to
5eaf799Comparedevnexen
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgsqlCopyFromArray() feeds each row through try_convert_to_string(). A non-stringable row throws a TypeError, but both the array and iterator branches then call pdo_pgsql_error() and record a fabricated PGRES_FATAL_ERROR, so after the exception unwinds PDO::errorInfo() reports "HY000" for what is a client-side type error (visible under ERRMODE_SILENT). Returning through the pending exception leaves errorInfo() clean.