Skip to content

Make Opcache tests using the cli server more reliable - #2259

Closed
mhagstrand wants to merge 1 commit into
php:masterfrom
mhagstrand:FixOpcacheTests
Closed

Make Opcache tests using the cli server more reliable#2259
mhagstrand wants to merge 1 commit into
php:masterfrom
mhagstrand:FixOpcacheTests

Conversation

@mhagstrand

Copy link
Copy Markdown
Contributor

Same fix applied to ext/curl/tests/server.inc
and sapi/cli/tests/php_cli_server.inc

  1. Increases the amount of time for the PHP built-in server to accept a connection
  2. Outputs an error if the PHP built-in server fails

Comment threadext/opcache/tests/php_cli_server.inc Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, please remove unrelated indents change.

Same fix already applied to ext/curl/tests/server.inc
and sapi/cli/tests/php_cli_server.inc
1. Increases the amount of time for the PHP built-in server to accept a connection
2. Outputs an error if the PHP built-in server fails
@mhagstrand

Copy link
Copy Markdown
ContributorAuthor

I have made the indentation changes that were requested.

@php-pulls

Copy link
Copy Markdown

Comment on behalf of krakjoe at php.net:

labelling

@nikic

nikic commented Dec 29, 2016

Copy link
Copy Markdown
Member

I'll hijack this PR to collect more flaky tests as I notice them:

  • ext/openssl/tests/openssl_pkey_new_basic.phpt (key bits vary -- can be 127 instead of 128)
  • ext/openssl/tests/ecc.phpt (key bits vary -- d can be 47 instead of 48)
  • ext/sysvsem/tests/nowait.phpt (usleep based, sometimes child comes first)
  • ext/session/tests/session_set_save_handler_basic.phpt (unlink(/home/travis/build/php/php-src/ext/session/tests/session_test_a406cd8d0e60cb8b8038f26d4930cba1): No such file or directory)
  • Zend/tests/concat_003.phpt (I already increased the timing limits here once, but it's still regularly failing)

@mhagstrand

mhagstrand commented Dec 29, 2016

Copy link
Copy Markdown
ContributorAuthor

So this patch fixes the intermittently failing test:

  • ISSUE Submitting test from testFest #115 (path issue when using phar) [ext/opcache/tests/issue0115.phpt]
  • revalidate_path01: OPCache must cache only resolved real paths when revalidate_path is set [ext/opcache/tests/revalidate_path_01.phpt]

Here is another intermittent failing test, I have seen not on your list:

  • openssl_*() with OPENSSL_KEYTYPE_EC [ext/openssl/tests/ecc.phpt] - 2497ae0

@nikic

Copy link
Copy Markdown
Member

PR merged via d0fcc74, thanks!

I've also fixed the pkey_new test with 78675eb.

Do you have a diff for the ecc test?

@nikicnikic closed this Dec 29, 2016
@nikic

Copy link
Copy Markdown
Member

Took another stab at concat_003 in 432660f. If it's still flaky after that I think we should just drop the test.

@nikic

Copy link
Copy Markdown
Member

The ecc.phpt test hopefully resolved by 2497ae0.

@mhagstrand

Copy link
Copy Markdown
ContributorAuthor

I have made a fix for nowait.phpt test in the PR
#2266

@mhagstrand
mhagstrand deleted the FixOpcacheTests branch January 2, 2017 21:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mhagstrand@php-pulls@nikic@laruence