Uh oh!
There was an error while loading. Please reload this page.
Zend: refactor zend_parse_arg_impl() to return zend_expected_type - #23052
Draft
Girgias wants to merge 5 commits into
Draft
Zend: refactor zend_parse_arg_impl() to return zend_expected_type#23052Girgias wants to merge 5 commits into
Girgias wants to merge 5 commits into
Conversation
This effectively mimics part of what Fast ZPP does and allows us to re-use the fast ZPP error APIs
And stop throwing the exceptions directly Means we restored back the original error message behaviour that's possibly not ideal
Removing the usage of zpp_error and allowing 'slow' ZPP to reuse the error logic
Girgiasforce-pushed
the
2026-08-old-zpp-use-error-msg
branch
from
August 5, 2026 00:59
feae6eb to
c471e54Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively mimics part of what Fast ZPP does and allows us to re-use the fast ZPP error APIs
I have actually continued refactoring this to the logical conclusion, but happy to split the latter bits into separate PRs so this is more easily review-able.