Skip to content

ext/mysqli: Deprecate mysqli_stmt_init - #23209

Merged
kamil-tekiela merged 2 commits into
php:masterfrom
kamil-tekiela:Deprecate-mysqli_stmt_init
Aug 14, 2026
Merged

ext/mysqli: Deprecate mysqli_stmt_init#23209
kamil-tekiela merged 2 commits into
php:masterfrom
kamil-tekiela:Deprecate-mysqli_stmt_init

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Member

This was mostly replacing mysqli_stmt_init + mysqli_stmt_prepare with mysqli_prepare.

The unrelated changes are either fixing typos or removing dead code.

@@ -31,12 +30,9 @@ require_once 'skipifconnectfailure.inc';
echo $exception->getMessage() . "\n";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo$exception::class, ': ', $exception->getMessage(), "\n";

If you want while you are on it.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, let's do that separately. This PR already has too many unrelated changes.

@DanielEScherzerDanielEScherzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase this and regenerate the arginfo, it will use the new ZEND_STR_8_DOT_6 known string, see #23222

@kamil-tekiela

Copy link
Copy Markdown
MemberAuthor

please rebase this and regenerate the arginfo, it will use the new ZEND_STR_8_DOT_6 known string, see #23222

Do I have to modify the stub file again?

@DanielEScherzer

Copy link
Copy Markdown
Member

please rebase this and regenerate the arginfo, it will use the new ZEND_STR_8_DOT_6 known string, see #23222

Do I have to modify the stub file again?

no, just run the gen_stub script

@kamil-tekiela
kamil-tekielaforce-pushed the Deprecate-mysqli_stmt_init branch from f6ecbac to 9f7c6c8CompareAugust 11, 2026 22:45
@kamil-tekiela

Copy link
Copy Markdown
MemberAuthor

Adding whitespace, regenarating and removing whitespace worked.

@DanielEScherzer

Copy link
Copy Markdown
Member

Adding whitespace, regenarating and removing whitespace worked.

Ah, I guess that if the stub file hasn't changed it wouldn't run again by default, I just always use build/gen_stub.php -f --generate-optimizer-info --verify so I forgot about that

@NickSdot

NickSdot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

CI failure looks like it's something running tests in parallel exposed. I am on it.

Edit: opened #23225

Comment threadNEWS Outdated
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
@kamil-tekielakamil-tekiela changed the title Deprecate mysqli_stmt_initext/mysqli: Deprecate mysqli_stmt_initAug 13, 2026
@kamil-tekiela
kamil-tekiela merged commit fd8706c into php:masterAug 14, 2026
18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kamil-tekiela@DanielEScherzer@NickSdot@kocsismate