Bug #38917 - Native SPKAC support request by jas- · Pull Request #267 · php/php-src

jas- · 2013-01-30T16:12:13Z

Wed Jan 30 09:06:49 MST 2013 - Pull request addressing feature request #38917 for native SPKAC support. Four new functions along with test cases:

(string) openssl_spki_new((object) private_key, (string) challenge, (int) algorithm)
(bool) openssl_spki_verify((string) spkac)
(string) openssl_spki_export((string) spkac)
(string) openssl_spki_export_challenge((string) spkac)

… patch for bug id #61421

…hm types

…dividual files as requested

… clean up any memory leaks

…t #38917 for native SPKAC support. Four new functions along with test cases: openssl_spki_new(), openssl_spki_verify(), openssl_spki_export(), openssl_spki_export_challenge()

smalyshev · 2013-02-17T09:35:46Z

Is this supposed to be part of the patch too? Discussion does not mention it...

smalyshev · 2013-02-17T10:01:28Z

It would be nice to also add some tests for failure scenarios.

smalyshev · 2013-02-17T10:08:45Z

These variables are not initialized. This leads to segfault of wrong string.

smalyshev · 2013-02-17T10:09:41Z

This code segfaults: php -r 'var_dump(openssl_spki_export("2438"));'
Probably because of missing variable initializations. Please clean it up and add failure scenario tests.

jas- · 2013-02-20T11:15:26Z

@smalyshev I have fixed the requested memory leak, changed the internal function away from the proto keyword and created error test cases as requested. Thanks for your help!

…s to accomidate failures

…NING in openssl_spki_new()

jas- · 2013-03-30T16:48:31Z

@smalyshev sorry if your busy with other things, when you get a minute I was just wondering about the status of this patch.

smalyshev · 2013-03-31T02:58:40Z

@jas- Well, right now for 5.5 we need approval of the RM (Julien Pauli) or we'll have to wait for 5.5.1.

jas- · 2013-03-31T04:57:55Z

Great, thanks!

* PHP-5.4: (22175 commits) fix valgrind warning Fix bug #64023 (__toString() & SplFileInfo) Fix test related to change for #bug64007 and also fix in newInstanceArgs NEWS: Start PHP 5.5.0 Beta 1 section NEWS for PHP 5.5.0alpha4 Fix NEWS fix tests Merge fix of #62836 to ?.re, and regenerate ?.c Fixed bug #64007 (There is an ability to create instance of Generator by hand). - Fixed ZTS build Class Name Resolution As Scalar Via "class" Keyword fix bug #63462 (Magic methods called twice for unset protected properties) NEWS for bug #64011. See 77ee200 Fix bug #64011 (get_html_translation_table()) Update config.sub to latest GPLv2 upstream version Fixed bug #63988 (Two Date tests fail) only for PHP-5.5 Fix skipif section Added ARM accelerated implementations for ZEND_SIGNED_MULTIPLY_LONG() Added test cases for ZEND_SIGNED_MULTIPLY_LONG() Fix News ...

* PHP-5.5: Sat Apr 7 21:02:37 MDT 2012 - Fixed segfaults and should just need to clean up any memory leaks Tue Apr 3 22:27:41 MDT 2012 - Split SPKI family of test cases into individual files as requested Tue Apr 3 21:21:20 MDT 2012 - Additional checks for supported algorithm types Tue Apr 3 14:41:40 MDT 2012 - SPKI functions, recommended changes and patch for bug id #61421 Tue Apr 3 14:40:49 MDT 2012 - SPKI functions, recommended changes and patch for bug id #61421 Conflicts: ext/openssl/openssl.c ext/openssl/tests/openssl_spki_export.phpt ext/openssl/tests/openssl_spki_export_challenge.phpt ext/openssl/tests/openssl_spki_new.phpt ext/openssl/tests/openssl_spki_verify.phpt

pierrejoye · 2013-04-30T20:32:27Z

Can you do a PR with the latest code? Or request an account to maintain it in ext/openssl? add me as sponsor.

Thanks for your work!

jas- · 2013-05-01T16:57:01Z

No problem, its only a small contribution @pierrejoye. I ran into some snags getting the upstream PHP 5.5 changes merged into my local branch but they have been resolved and all changes should now be in this pull request.

Asking for an account involves posting a message to internals I am assuming?

kaplanlior · 2013-07-17T22:40:11Z

@jas- a mail to internals would be a good start, but you also have to use this form: http://www.php.net/git-php.php

jas- · 2013-07-17T23:16:13Z

Strange, that happened quite a while ago and was pushed to master @ git.php.net. I believe there is a freeze on new features which is why it isn't closed yet

Jason Gerfen

http://www.github.com/jas-

On Jul 17, 2013, at 4:40 PM, Lior Kaplan notifications@github.com wrote:

@jas- a mail to internals would be a good start, but you also have to use this form: http://www.php.net/git-php.php
—
Reply to this email directly or view it on GitHub.

kaplanlior · 2013-07-17T23:24:53Z

@jas- You're right, committed in http://git.php.net/?p=php-src.git;a=commit;h=8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4 and the bug should also be closed.

php-pulls · 2013-07-18T07:53:25Z

Comment on behalf of stas at php.net:

merged

…ng out 5.6. see #267

rootand others added 7 commits April 3, 2012 14:40

Tue Apr 3 14:40:49 MDT 2012 - SPKI functions, recommended changes and…
5cf494e
… patch for bug id #61421

Tue Apr 3 14:41:40 MDT 2012 - SPKI functions, recommended changes and…
6ae58bb
… patch for bug id #61421

Tue Apr 3 21:21:20 MDT 2012 - Additional checks for supported algorit…
b762149
…hm types

Tue Apr 3 22:27:41 MDT 2012 - Split SPKI family of test cases into in…
9cd5d13
…dividual files as requested

Sat Apr 7 21:02:37 MDT 2012 - Fixed segfaults and should just need to…
68bb889
… clean up any memory leaks

Wed Jan 23 08:49:01 MST 2013 - Synced upstream & patched current branch
33d2496

Wed Jan 30 09:06:49 MST 2013 - Pull request addressing feature reques…
820acea
…t #38917 for native SPKAC support. Four new functions along with test cases: openssl_spki_new(), openssl_spki_verify(), openssl_spki_export(), openssl_spki_export_challenge()

jas- mentioned this pull request Jan 30, 2013
SPKAC functionality per feature request #38917 (part deux) #37
Closed

smalyshev reviewed Feb 17, 2013
View reviewed changes

Comment threadext/openssl/openssl.c Outdated
smalyshevFeb 17, 2013
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables are not initialized. This leads to segfault of wrong string.

jas- added 2 commits February 20, 2013 04:16

Wed Feb 20 04:16:25 MST 2013 - Fixed memory leaks. Expanded test case…
d363b47
…s to accomidate failures

Sun Mar 3 19:06:44 MST 2013 - Removed E_ERROR and replaced with E_WAR…
777a1d8
…NING in openssl_spki_new()

jas- mentioned this pull request Apr 8, 2013
Crash with PHP 5.5 beta 2 jas-/SPKAC-PHP-OpenSSL#1
Closed

jas- added 7 commits April 28, 2013 22:34

Sun Apr 28 22:34:52 MDT 2013 - Merged master with upstream from php-src
617c3a9

Sun Apr 28 23:04:28 MDT 2013 - Resolving rebase
63620da

Merge branch 'issue-38917-spkac', remote branch 'upstream/master'
307f201

Mon Apr 29 00:11:12 MDT 2013 - Merge
e67d3be

Mon Apr 29 01:12:33 MDT 2013 - Working copy
9748d6c

php-pulls closed this Jul 18, 2013

Tyrael added a commit that referenced this pull request Feb 3, 2014
mention the openssl SPKAC functions commited to master before branchi…
5d3a2fd
…ng out 5.6. see #267

dunglas mentioned this pull request Sep 17, 2023
Segmentation fault when building Symfony cache on Alpine #12234
Closed

Uh oh!

Conversation

jas- commented Jan 30, 2013

Uh oh!

smalyshevFeb 17, 2013

Choose a reason for hiding this comment

Uh oh!

smalyshev commented Feb 17, 2013

Uh oh!

smalyshevFeb 17, 2013

Choose a reason for hiding this comment

Uh oh!

smalyshev commented Feb 17, 2013

Uh oh!

jas- commented Feb 20, 2013

Uh oh!

jas- commented Mar 30, 2013

Uh oh!

smalyshev commented Mar 31, 2013

Uh oh!

jas- commented Mar 31, 2013

Uh oh!

pierrejoye commented Apr 30, 2013

Uh oh!

jas- commented May 1, 2013

Uh oh!

kaplanlior commented Jul 17, 2013

Uh oh!

jas- commented Jul 17, 2013

Uh oh!

kaplanlior commented Jul 17, 2013

Uh oh!

php-pulls commented Jul 18, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants