Uh oh!
There was an error while loading. Please reload this page.
Cleanup of remaning E_STRICT - #4401
Conversation
nikic
commented
Jul 14, 2019
Can you please separate out the two changes that affect where E_STRICT is thrown? |
Girgias
commented
Jul 14, 2019
Done :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
This should be kept with E_STRICT replaced with something else, I think. Possibly just a dummy value (if hex is supported, something like 0x100000), as this is a parsing test.
There was a problem hiding this comment.
There are a bunch of whitespaces after are those part of the test too?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
26a1307 to
a1053d0CompareClosed and Reopened to restart CI after I messed up my rebase and it didn't pick up on the quick subsequent push Edit: nope just another file I missed after i f* the rebase onto upstream >__> |
Girgias
commented
Jul 19, 2019
Windows test failure seems unrelated. |
nikic
commented
Jul 23, 2019
Merged as 6d6d954, thanks! |
Removed usage of E_STRICT in a couple of places by using lxr [1]
I've converted the last usages to
E_NOTICEhowever as @nikic is the author of the RFC to reclassify them [2] could you have a look at them?Removed the E_STRICT in the default error handling mode as this shouldn't trigger anything more now.
Not sure if we should keep the mention of E_STRICT in the INI files, I've removed them as they seem pointless ATM.
The constant still exists in the Zend engine which we may want to remove in PHP 8.
[1] https://lxr.room11.org/search?project=php-src%407.4&q=E_STRICT&defs=&refs=&path=&hist=&type=
[2] https://wiki.php.net/rfc/reclassify_e_strict