Skip to content

Check for Windows utf-8 support in run-tests.php - #4404

Closed
TysonAndre wants to merge 1 commit into
php:PHP-7.4from
TysonAndre:windows-terminal-nit
Closed

Check for Windows utf-8 support in run-tests.php#4404
TysonAndre wants to merge 1 commit into
php:PHP-7.4from
TysonAndre:windows-terminal-nit

Conversation

@TysonAndre

Copy link
Copy Markdown
Contributor

Windows terminals can have different codepages.
In some locales (especially in older OS versions),
the default codepage isn't necessarily utf-8.
Non-utf8 codepages wouldn't render this utf-8 character properly.

This is based on a similar utf-8 check in a different application : phan/phan@874e908#diff-c47b128e8e4f783d984687a8796dc74dR1464

Windows terminals can have different codepages.
In some locales (especially in older OS versions),
the default codepage isn't necessarily utf-8.
Non-utf8 codepages wouldn't render this utf-8 character properly.
@TysonAndre
TysonAndre changed the base branch from master to PHP-7.4July 14, 2019 18:55
@nikic

Copy link
Copy Markdown
Member

I'd suggest to just drop the lightning instead...

@TysonAndre

Copy link
Copy Markdown
ContributorAuthor

I'm ambivalent about keeping or removing the lightning. This just seemed like a quick fix that could get approved without objection or reverts - #3981 (comment) also brought up the --no-ansi option, #2822 (review) mentioned these objections

Ideally php would have a native cross-platform equivalent of terminal[_probably]_supports_utf8()

@nikic

Copy link
Copy Markdown
Member

Lightning removed in 562591f.

@nikicnikic closed this Jul 18, 2019
@cmb69

Copy link
Copy Markdown
Member

See also 55d34f7.

@TysonAndre
TysonAndre deleted the windows-terminal-nit branch October 7, 2019 13:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TysonAndre@nikic@cmb69