Skip to content

Convert remaining array function arginfo to PHP stubs - #4543

Closed
theodorejb wants to merge 16 commits into
php:masterfrom
theodorejb:array_function_stubs
Closed

Convert remaining array function arginfo to PHP stubs#4543
theodorejb wants to merge 16 commits into
php:masterfrom
theodorejb:array_function_stubs

Conversation

@theodorejb

@theodorejbtheodorejb commented Aug 15, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Also updates gen_stub.php to support ZEND_SEND_PREFER_REF arguments, and check that only the last parameter is variadic.

nikic
nikic reviewed Aug 15, 2019
View reviewed changes
Comment threadext/standard/basic_functions.stub.php Outdated
nikic
nikic reviewed Aug 16, 2019
View reviewed changes
Comment threadext/standard/basic_functions.stub.php Outdated
@theodorejbtheodorejb mentioned this pull request Aug 20, 2019
Closed
nikic
nikic reviewed Aug 20, 2019
View reviewed changes
Comment threadscripts/dev/gen_stub.php
Comment threadext/standard/basic_functions.stub.php
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
Comment threadext/standard/basic_functions.stub.php Outdated
nikic
nikic reviewed Aug 26, 2019
View reviewed changes
Comment threadext/standard/basic_functions.stub.php
@nikic

nikic commented Aug 26, 2019

Copy link
Copy Markdown
Member

Merged as d5f42d6 with the above tweak. Thanks!

@nikicnikic closed this Aug 26, 2019
@nikic

nikic commented Aug 26, 2019

Copy link
Copy Markdown
Member

Followup in 0038db2 to fix the duplicate warning.

@theodorejb
theodorejb deleted the array_function_stubs branch August 27, 2019 01:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GirgiasGirgiasGirgias left review comments
+1 more reviewer
@nikicnikicnikic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Stubs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theodorejb@nikic@Girgias@cmb69