Skip to content

Promote warnings to error in array_fill() - #4576

Closed
Girgias wants to merge 1 commit into
php:masterfrom
Girgias:fill-array-warning2error
Closed

Promote warnings to error in array_fill()#4576
Girgias wants to merge 1 commit into
php:masterfrom
Girgias:fill-array-warning2error

Conversation

@Girgias

Copy link
Copy Markdown
Member

Split from #4566

@GirgiasGirgias changed the title Promote warnings to error in array_flip()Promote warnings to error in array_fill()Aug 20, 2019
Comment threadext/standard/array.c
/* }}} */

/* {{{ proto array|false array_fill(int start_key, int num, mixed val)
/* {{{ proto array array_fill(int start_key, int num, mixed val)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stub return type also needs to be updated.

@Girgias

Copy link
Copy Markdown
MemberAuthor

This probably needs to wait the result of the Reclassifying Engine Warnings RFC wrt to the "Cannot add element to the array as the next element is already occupied" warning, which also prevents a return type modification in the stubs.

@Girgias
Girgias deleted the fill-array-warning2error branch November 20, 2019 19:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Girgias@nikic@theodorejb@krakjoe@kocsismate@carusogabriel