Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to errors in extract() - #4588
Closed
Girgias wants to merge 4 commits into
Closed
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nikic
reviewed
Aug 27, 2019
Uh oh!
There was an error while loading. Please reload this page.
theodorejb
left a comment
Contributor
There was a problem hiding this comment.
Is the return type still int|null? If it is no longer nullable, the proto comment should be updated as well as the stub signature.
Girgiasforce-pushed
the
extract-warnings2error
branch
from
August 27, 2019 23:02
5d9b905 to
f637118CompareGirgias
commented
Aug 27, 2019
MemberAuthor
I don't think it can return null any more so I've updated the stubs. |
nikic
approved these changes
Aug 28, 2019
nikic
suggested changes
Aug 28, 2019
Girgias
commented
Aug 28, 2019
MemberAuthor
Yeah I forgot those were covered in the normal error ones. Removed them and merged as 70e604e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #4566