Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to errors in chunk_split() - #4603
Closed
Girgias wants to merge 1 commit into
Closed
Conversation
nikic
approved these changes
Aug 22, 2019
nikic
left a comment
Member
There was a problem hiding this comment.
Side note: We should take a look at the error conditions inside php_chunk_split(). They currently result in silent(!) failure :(
Girgias
commented
Aug 22, 2019
MemberAuthor
I'll have a look at them |
Girgias
commented
Aug 22, 2019
MemberAuthor
Merged in as f51421c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #4554