Uh oh!
There was an error while loading. Please reload this page.
Remove 'bogus' error condition in str_pad() - #4613
Merged
Merged
Conversation
nikic
commented
Aug 23, 2019
Member
Fatal error is correct here. You'll have to adjust the test expectation for debug builds though (you can make liberal use of |
Girgias
commented
Aug 23, 2019
MemberAuthor
Same should be done for chunk_split then I imagine. |
Girgiasforce-pushed
the
bogus-check-str-pad
branch
from
August 23, 2019 23:29
8b6632b to
cf2adfdCompareKalleZ
reviewed
Aug 24, 2019
Uh oh!
There was an error while loading. Please reload this page.
Girgiasforce-pushed
the
bogus-check-str-pad
branch
from
August 24, 2019 13:57
cf2adfd to
49059c2CompareGirgiasforce-pushed
the
bogus-check-str-pad
branch
from
August 24, 2019 14:05
49059c2 to
9d18f23Comparenikic
approved these changes
Aug 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per @nikic request in #4601 (comment)
I'm not entirely sure we should drop it but more fix it in a way that memory allocation doesn't fail. Or is the fatal error alright ? Because even with the current check a fatal error is possible (see variation5 test)