Uh oh!
There was an error while loading. Please reload this page.
Don't call __set() on uninitialized typed properties (Z_EXTRA variant) - #4856
Closed
nikic wants to merge 2 commits into
Closed
Don't call __set() on uninitialized typed properties (Z_EXTRA variant)#4856nikic wants to merge 2 commits into
nikic wants to merge 2 commits into
Conversation
dstogov
approved these changes
Oct 24, 2019
Member
There was a problem hiding this comment.
Better to introduce special macros instead of generic Z_EXTRA_P(), to easily find all relevant usages.
Member
There was a problem hiding this comment.
Here and later: better to keep the existing code under #if 0 with comments about optimization (or introduce special macro ZVAL_COPY_PROP_VALUE)
Also don't set it for static properties -- this is only relevant for instance properties, as static properties have no __set().
nikicforce-pushed
the
uninit-prop-magic-set-2
branch
from
October 25, 2019 14:02
64faaec to
68b54e7Comparenikic
commented
Oct 25, 2019
MemberAuthor
Merged as f1848a4. |
Majkl578
commented
Oct 26, 2019
Contributor
Ad:
I suppose this is just another case that could be solved by having property accessors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #4854 but based on Z_EXTRA rather than TYPE_FLAG.