Change warnings to Errors in Date extension

[Girgias]

No description provided.

[derickr]

I'm not so keen, as this is a BC break.

[Girgias]

I'm not so keen, as this is a BC break.

Are you opposed to the change in general or to some specific instances?

Because some of them do fall in line with the various other changes I've made to throw on programming/logic errors.

[cmb69]

In my opinion, some of these changes are fine (e.g. throwing on "Timezone database is corrupt"), but some appear to be too aggressive (e.g. throwing on "Failed to parse interval"). Basically, it boils down to whether the programmer has a chance to validate user-supplied input, or whether it would be necessary to try calling the function/method.

[Girgias]

In my opinion, some of these changes are fine (e.g. throwing on "Timezone database is corrupt"), but some appear to be too aggressive (e.g. throwing on "Failed to parse interval"). Basically, it boils down to whether the programmer has a chance to validate user-supplied input, or whether it would be necessary to try calling the function/method.

Which seems totally reasonable, I'll need to rebase and rework this anyway when I've got time to use the new argument version of the Value errors.

[Girgias]

Superseded by #5613