Skip to content

Convert some warnings to Errors in BZip2 - #4984

Closed
Girgias wants to merge 1 commit into
php:masterfrom
Girgias:bz2-warnings-to-error
Closed

Convert some warnings to Errors in BZip2#4984
Girgias wants to merge 1 commit into
php:masterfrom
Girgias:bz2-warnings-to-error

Conversation

@Girgias

@GirgiasGirgias commented Dec 8, 2019

Copy link
Copy Markdown
Member

No description provided.

nikic
nikic reviewed Dec 8, 2019
View reviewed changes
Comment threadext/bz2/bz2.c Outdated
Comment threadext/bz2/bz2.c Outdated
Comment threadext/bz2/bz2_filter.c Outdated
@GirgiasGirgias mentioned this pull request Dec 8, 2019
Merged
nikic
nikic reviewed Jan 3, 2020
View reviewed changes
Comment threadext/bz2/bz2.c Outdated
nikic
nikic reviewed Jan 3, 2020
View reviewed changes
Comment threadext/bz2/tests/bug72447.phpt Outdated
@Girgias
Girgiasforce-pushed the bz2-warnings-to-error branch from cc46f1b to a3695baCompareJanuary 7, 2020 18:42
kocsismate
kocsismate reviewed Jan 7, 2020
View reviewed changes
Comment threadext/bz2/bz2.c Outdated
@kocsismate

kocsismate commented Jan 7, 2020

Copy link
Copy Markdown
Member

@cmb69 I was thinking about how to best collect all the warning promotions to a change log (regarding https://externals.io/message/107931). Wouldn't using a separate GitHub label (similar to stubs) help there?

@Girgias
Girgiasforce-pushed the bz2-warnings-to-error branch from a3695ba to 9c612e0CompareJanuary 7, 2020 19:57
@cmb69

cmb69 commented Jan 7, 2020

Copy link
Copy Markdown
Member

@kocsismate, yes, I think a label would be useful. Any idea on how to name it (and which color to choose)?

@kocsismate

kocsismate commented Jan 8, 2020

Copy link
Copy Markdown
Member

My preferences are Warning promotion(s) and a colour which is close to red :) But feel free to suggest a better name/colour.

@cmb69

cmb69 commented Jan 8, 2020

Copy link
Copy Markdown
Member

Is that okay?

@kocsismate

kocsismate commented Jan 8, 2020

Copy link
Copy Markdown
Member

Of course! :) Thanks!

nikic
nikic approved these changes Jan 8, 2020
View reviewed changes
Comment threadext/bz2/bz2.c
Comment threadext/bz2/bz2.c
cmb69
cmb69 reviewed Jan 8, 2020
View reviewed changes
Comment threadext/bz2/bz2.c
@Girgias
Girgias deleted the bz2-warnings-to-error branch January 8, 2020 23:59
@GirgiasGirgias mentioned this pull request Aug 13, 2020
Closed
71 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments
@kocsismatekocsismatekocsismate left review comments
+1 more reviewer
@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Warning promotion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Girgias@kocsismate@cmb69@nikic