Uh oh!
There was an error while loading. Please reload this page.
Convert some warnings to Error in zlib extension - #4985
Conversation
Girgias
commented
Dec 30, 2019
If there are no objections I'll rebase and merge this next week. |
Shouldn't this line also be changed to throw? I was only scrolling to that function because I was interested in seeing whether partial data fed to a zlib inflate context would throw now with this PR. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nikic
commented
Jan 3, 2020
No, this should not throw Error, as it's an expected condition. |
ae719c0 to
d2ed399Compare
nikic
left a comment
There was a problem hiding this comment.
LG. Would be great if you could also change the error messages to capitalize the first character.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.