Skip to content

Fix #78666 mysqli_options generates Warning on var_dump() - #5121

Closed
kocsismate wants to merge 2 commits into
php:PHP-7.4from
kocsismate:mysqli-var-dump
Closed

Fix #78666 mysqli_options generates Warning on var_dump()#5121
kocsismate wants to merge 2 commits into
php:PHP-7.4from
kocsismate:mysqli-var-dump

Conversation

@kocsismate

@kocsismatekocsismate commented Jan 27, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Split off from #5058

If changing the signature of mysqli functions is too late for PHP 7.4, I can switch the base branch to master.

There is one test that fails (bug54221.phpt), but I can't find out exactly why...

@Girgias

Girgias commented Jan 27, 2020

Copy link
Copy Markdown
Member

Bug fixes should target the lowest supported version, currently 7.3.

nikic
nikic reviewed Jan 27, 2020
View reviewed changes
Comment threadext/mysqli/mysqli.c Outdated
nikic
nikic reviewed Jan 27, 2020
View reviewed changes
Comment threadext/mysqli/tests/bug28817.phpt Outdated
@nikic

nikic commented Jan 27, 2020

Copy link
Copy Markdown
Member

I'd say this is okay for 7.4 (mysqli_property_entry is technically part of an exported header, but the type is not used in exported APIs). For 7.3 this change is too large.

@kocsismate
kocsismateforce-pushed the mysqli-var-dump branch 4 times, most recently from 26b889c to 1bc86deCompareJanuary 28, 2020 09:35
kocsismate
kocsismate commented Jan 28, 2020
View reviewed changes
Comment threadext/mysqli/mysqli.c Outdated
nikic
nikic reviewed Jan 28, 2020
View reviewed changes
Comment threadext/mysqli/mysqli.c Outdated
Comment threadext/mysqli/mysqli.c Outdated
Comment threadext/mysqli/mysqli_driver.c Outdated
Comment threadext/mysqli/mysqli_warning.c
nikic
nikic reviewed Jan 28, 2020
View reviewed changes
Comment threadext/mysqli/tests/mysqli_result_references.phpt Outdated
Comment threadext/mysqli/mysqli_warning.c
@kocsismate
kocsismateforce-pushed the mysqli-var-dump branch 2 times, most recently from 3bb6b03 to 0d250c8CompareJanuary 28, 2020 14:50
@kocsismate
kocsismate deleted the mysqli-var-dump branch January 28, 2020 17:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kocsismate@Girgias@nikic