Create str_contains PHP function - #5179

Closed
philippta wants to merge 3 commits into
php:masterfrom
philippta:str_contains
Closed

Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom
philippta:str_contains

Conversation

@philippta

@philipptaphilippta commented Feb 13, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.

This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.

I would like to propose the new function str_contains:

str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.

Example:

<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false

@nikicnikic added the RFC label Feb 13, 2020
nikic
nikic reviewed Feb 13, 2020
View reviewed changes

@nikicnikic left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).

Comment threadext/standard/basic_functions_arginfo.h Outdated
@philippta

philippta commented Feb 14, 2020

Copy link
Copy Markdown
ContributorAuthor

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).

This sounds great. I will go ahead and create an RFC for this.

@jrbasso

jrbasso commented Feb 16, 2020

Copy link
Copy Markdown
Contributor

To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.

@Girgias

Girgias commented Feb 16, 2020

Copy link
Copy Markdown
Member

To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.

See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.

@philippta

philippta commented Feb 17, 2020

Copy link
Copy Markdown
ContributorAuthor

An RFC has been created: https://wiki.php.net/rfc/str_contains

@laruence

laruence commented Feb 21, 2020•
edited
Loading

Copy link
Copy Markdown
Member

I am not sure what is the difference between this and if (strpos === false).

@KennedyTedesco

KennedyTedesco commented Feb 21, 2020

Copy link
Copy Markdown
Contributor

To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.

@lcobucci

lcobucci commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍

@philippta

philippta commented Mar 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time

Tests have been added.

@Gemorroj

Gemorroj commented Mar 14, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

what about multibyte support?

// UTF-8str_contains("тест", "т"); // ???

@Girgias

Girgias commented Mar 14, 2020

Copy link
Copy Markdown
Member

what about multibyte support?

// UTF-8
str_contains("тест", "т"); // ???

That would return true

@Gemorroj

Gemorroj commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");

str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases

@Girgias

Girgias commented Mar 14, 2020

Copy link
Copy Markdown
Member

@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");

str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases

... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)
The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment
@Girgias

Girgias commented Mar 14, 2020

Copy link
Copy Markdown
Member

@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");

str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases

... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)
The RFC also says why it is not in the proposal: #5179 (comment)

@Gemorroj

Gemorroj commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Have you read this PR thread and or the RFC?

No. But now yes. There are answers to all my questions. Thanks.
It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.

@philippta

philippta commented Mar 16, 2020

Copy link
Copy Markdown
ContributorAuthor

The RFC has been accepted and the voting phase has been closed.
It is now ready to be merged.

@carusogabrielcarusogabriel added this to the PHP 8.0 milestone May 29, 2020
@scottchiefbaker

scottchiefbaker commented May 30, 2020

Copy link
Copy Markdown

Are there official polyfills for the new this and the other new string functions?

@Gemorroj

Gemorroj commented May 30, 2020

Copy link
Copy Markdown
Contributor

@scottchiefbakerhttps://github.com/symfony/polyfill-php80

@scottchiefbaker

scottchiefbaker commented May 30, 2020•
edited
Loading

Copy link
Copy Markdown

@Gemorroj perfect, thank you

@leernd007

leernd007 commented Jun 3, 2020

Copy link
Copy Markdown

I am not sure what is the difference between this and if (strpos === false).

Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:

not very intuitive for a reader
easy to get wrong (especially with the !== comparison)
or hard to remember for new PHP developers.

https://wiki.php.net/rfc/str_contains

@sfaut

sfaut commented Jul 13, 2020

Copy link
Copy Markdown

I am not sure what is the difference between this and if (strpos === false).

Empty string management differs. strpos('foo', '') emits a warning and returns false.

When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.

franzholz added a commit to franzholz/typo3db_legacy that referenced this pull request Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz mentioned this pull request Jan 15, 2022
Merged
@dani7115

dani7115 commented May 7, 2022

Copy link
Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally

kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis mentioned this pull request Nov 29, 2022
Closed
5 tasks
Davidmattei added a commit to Davidmattei/elasticms that referenced this pull request Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit to franz-agency/zetacomponents-Authentication that referenced this pull request Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments
+1 more reviewer
@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

RFC

Projects

None yet

Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Create str_contains PHP function - #5179
Closed
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Closed
Create str_contains PHP function#5179
philippta wants to merge 3 commits into
php:masterfrom 
philippta:str_contains
Conversation
@philippta
@philipptaphilippta
commented
Feb 13, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.
This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.
I would like to propose the new function str_contains:
str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.
Example:
<?phpstr_contains("abc", "a"); // truestr_contains("abc", "d"); // false
@nikicnikic
added
the 
RFC

label
Feb 13, 2020
nikic
nikic
reviewed
Feb 13, 2020
View reviewed changes
@nikicnikic
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
Comment threadext/standard/basic_functions_arginfo.h
Outdated

@philippta
philippta
commented
Feb 14, 2020

Copy link


Copy Markdown

ContributorAuthor
I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).
This sounds great. I will go ahead and create an RFC for this.
@jrbasso
jrbasso
commented
Feb 16, 2020

Copy link


Copy Markdown

Contributor
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
@Girgias
Girgias
commented
Feb 16, 2020

Copy link


Copy Markdown

Member
To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.
See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.
@philippta
philippta
commented
Feb 17, 2020

Copy link


Copy Markdown

ContributorAuthor
An RFC has been created: https://wiki.php.net/rfc/str_contains
@laruence
laruence
commented
Feb 21, 2020•

edited

Loading

Copy link


Copy Markdown

Member
I am not sure what is the difference between this and if (strpos === false).
@KennedyTedesco
KennedyTedesco
commented
Feb 21, 2020

Copy link


Copy Markdown

Contributor
To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.
@lcobucci
lcobucci
commented
Mar 3, 2020

Copy link


Copy Markdown

Contributor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍
@philippta
philippta
commented
Mar 13, 2020

Copy link


Copy Markdown

ContributorAuthor
Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time
Tests have been added.
@Gemorroj
Gemorroj
commented
Mar 14, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
what about multibyte support?
// UTF-8str_contains("тест", "т"); // ???
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)

1 similar comment

@Girgias
Girgias
commented
Mar 14, 2020

Copy link


Copy Markdown

Member
@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases
... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)

The RFC also says why it is not in the proposal: #5179 (comment)
@Gemorroj
Gemorroj
commented
Mar 14, 2020

Copy link


Copy Markdown

Contributor
Have you read this PR thread and or the RFC?
No. But now yes. There are answers to all my questions. Thanks.

It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.
@philippta
philippta
commented
Mar 16, 2020

Copy link


Copy Markdown

ContributorAuthor
The RFC has been accepted and the voting phase has been closed.

It is now ready to be merged.
@carusogabrielcarusogabriel
added this to the PHP 8.0 milestone
May 29, 2020
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020

Copy link


Copy Markdown

Are there official polyfills for the new this and the other new string functions?
@Gemorroj
Gemorroj
commented
May 30, 2020

Copy link


Copy Markdown

Contributor
@scottchiefbakerhttps://github.com/symfony/polyfill-php80
@scottchiefbaker
scottchiefbaker
commented
May 30, 2020•

edited

Loading

Copy link


Copy Markdown

@Gemorroj perfect, thank you
@leernd007
leernd007
commented
Jun 3, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:
not very intuitive for a reader

easy to get wrong (especially with the !== comparison)

or hard to remember for new PHP developers.
https://wiki.php.net/rfc/str_contains
@sfaut
sfaut
commented
Jul 13, 2020

Copy link


Copy Markdown

I am not sure what is the difference between this and if (strpos === false).
Empty string management differs. strpos('foo', '') emits a warning and returns false.
When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.
franzholz added a commit
to franzholz/typo3db_legacy
that referenced
this pull request
Jan 15, 2022
@franzholz
Applied rules:
3c5c27a
 * RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@franzholzfranzholz
mentioned this pull request
Jan 15, 2022
 Merged

@dani7115
dani7115
commented
May 7, 2022

Copy link


Copy Markdown

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
c4487b6
Applied rules:
* TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object)
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
kenjis added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 29, 2022
@kenjis
refactor: upgrade to PHP 8.0 with rector
6c5297e
Applied rules:
* StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
@kenjiskenjis
mentioned this pull request
Nov 29, 2022
 Closed

5 tasks
Davidmattei added a commit
to Davidmattei/elasticms
that referenced
this pull request
Dec 1, 2022
@Davidmattei
chore(php8): rector common-bundle
0e5d4df
Applied rules:
* ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotionphp/php-src#5291)
* StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions)
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)
georgfranz added a commit
to franz-agency/zetacomponents-Authentication
that referenced
this pull request
Dec 11, 2023
@georgfranz
Update code base for php 8.2
ec73919
Applied rules:
* LongArrayToShortArrayRector
* TernaryToNullCoalescingRector
* PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility)
* ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntaxhttps://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring)
* MixedTypeRector
* StrContainsRector (https://externals.io/message/108562php/php-src#5179)
* ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2)
* FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const)
* NullToStrictStringFuncCallArgRector
* TypedPropertyFromAssignsRector
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments

+1 more reviewer

@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

RFC

Projects


None yet


Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

14 participants

@philippta@jrbasso@Girgias@laruence@KennedyTedesco@lcobucci@Gemorroj@scottchiefbaker@leernd007@sfaut@dani7115@nikic@cmb69@carusogabriel