Skip to content

Native Windows support for mysqlnd sha256 authentification - #5210

Closed
cmb69 wants to merge 5 commits into
php:PHP-7.4from
cmb69:cmb/mysqlnd-auth
Closed

Native Windows support for mysqlnd sha256 authentification#5210
cmb69 wants to merge 5 commits into
php:PHP-7.4from
cmb69:cmb/mysqlnd-auth

Conversation

@cmb69

@cmb69cmb69 commented Feb 25, 2020

Copy link
Copy Markdown
Member

We implement that on top of Cryptography API: Next Generation (CNG).

@cmb69
Abstract over crypto operations
361715a
@cmb69
Native Windows support for mysqlnd sha256 authentification
797a3fc
We implement that on top of Cryptography API: Next Generation (CNG).
@cmb69cmb69 mentioned this pull request Feb 25, 2020
Closed
@cmb69

cmb69 commented Feb 25, 2020

Copy link
Copy Markdown
MemberAuthor

@johannes, @andreyhristov, @weltling, you may want to review.

nikic
nikic reviewed Feb 26, 2020
View reviewed changes

@nikicnikic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Did you do some manual testing for this functionality? We don't have tests for it.

Comment threadext/mysqlnd/mysqlnd_auth.c Outdated
@cmb69

cmb69 commented Feb 26, 2020

Copy link
Copy Markdown
MemberAuthor

@nikic, thanks! I tested with MySQL 8.0.19 on Windows (users with caching_sha2_password and sha256_password authentication); all mysqli and pdo_mysql tests succeeded. I did not test on other systems.

andreyhristov
andreyhristov suggested changes Feb 26, 2020
View reviewed changes
Comment threadext/mysqlnd/mysqlnd_auth.c Outdated
Comment threadext/mysqlnd/mysqlnd_auth.c Outdated
Comment threadext/mysqlnd/mysqlnd_auth.c
Comment threadext/mysqlnd/mysqlnd_auth.c
Comment threadext/mysqlnd/mysqlnd_auth.c Outdated
@cmb69

cmb69 commented Feb 28, 2020

Copy link
Copy Markdown
MemberAuthor

Any further comments on this PR?

If there are no objections, I'll merge this on Monday, so it makes it into PHP 7.4.4 (obviously, some users are eagerly waiting for this functionality).

@cmb69

cmb69 commented Mar 2, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks! Applied as a7400d5 and a037702.

@cmb69cmb69 closed this Mar 2, 2020
@cmb69
cmb69 deleted the cmb/mysqlnd-auth branch March 2, 2020 15:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@nikicnikicnikic left review comments
@andreyhristovandreyhristovandreyhristov requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmb69@nikic@andreyhristov