Uh oh!
There was an error while loading. Please reload this page.
Remove deprecated mbstring INI settings - #5334
Conversation
cc1efa5 to
b445c11Compareb445c11 to
ed3cd54Compare133cbde to
ac8585eCompare1740be7 to
374deddCompare374dedd to
42f61feCompareGirgias
commented
May 22, 2020
@nikic can you have a look at this please? |
42f61fe to
b37c42bCompareb37c42b to
f015f9bCompareGirgias
commented
Jul 4, 2020
I've fixed the Windows compiler warning after the rebase onto master, I think this should be good to merge, can you double check @nikic? |
Girgias
commented
Jul 20, 2020
If there are no objections I'll merge this at the end of the week. |
alexdowad
commented
Oct 7, 2023
Hi @Girgias! Thanks very much! I need to investigate this change a bit more to make sure I understand what all the implications will be. (But otherwise, removing long-deprecated code is great!) |
Girgias
commented
Oct 10, 2023
IIRC the reason this was not merged in 8.0 was because prior to 7.4 those settings were still actually required. |
alexdowad
commented
Oct 15, 2023
Dear @Girgias, I really appreciate your working on this. I am just investigating this issue and believe that this patch might be more invasive than necessary or advisable. I am working on an alternative patch and hope to show it to you soon. |
Girgias
commented
Oct 15, 2023
Superseded by #12445 |
These INI settings were deprecated back in PHP 5.6.
I tried to adapt the tests but I'm not sure if some of them aren't wrong because I'm not totally sure what the behaviour should be.