Uh oh!
There was an error while loading. Please reload this page.
Allow arbitrary expressions for empty() - #54
Merged
Conversation
LinusU
commented
Apr 17, 2012
Contributor
I think that this is a great idea, thank you for taking the time to implement it! |
This change is as per RFC https://wiki.php.net/rfc/empty_isset_exprs. The change allows passing the result of function calls and other expressions to the empty() language construct. This is accomplished by simply rewriting empty(expr) to !expr. The change does not affect the suppression of errors when using empty() on variables. empty($undefinedVar) will continue not to throw errors. When an expression is used inside empty() on the other hand, errors will not be suppressed. Thus empty($undefinedVar + $somethingElse) *will* throw a notice. The change also does not make empty() into a real function, so using 'empty' as a callback is still not possible. In addition to the empty() changes the commit adds nicer error messages when isset() is used on function call results or other expressions.
php-pulls
commented
May 24, 2012
Comment on behalf of stas at php.net: merged to master, thanks |
1 similar comment
php-pulls
commented
May 24, 2012
Comment on behalf of stas at php.net: merged to master, thanks |
php-pulls pushed a commit
that referenced
this pull request
Mar 15, 2013
* PHP-5.5: (101 commits) Renamed ZendOptimizerPlus.so into opcache.so "ZendOptimizerPlus" is renamed to "opcache" to de merged into PHP-5.5 under ext/opcache (the product name is still "Zend Optimizer+") More accurate restart scheduling Autogolobal $GLOBALS has to be pinged even if auto_globals_jit=0 Allow only shared O+ build Fixed typos add tests into package Add test script for #57 (segfaults in drupal7) fixed memory leaks Fixed Issue #57 (segfaults in drupal7) Fixed issue #58 (PHP-5.2 compatibility) Allows exclusion of large files from being cached Add maintainers inot package.xml fix ANSI C90 compat Fixed test Fixed uninitialized variable Fixed bug #64353 (Built-in classes can be unavailable with dynamic includes and Optimizer+) Save a stat() call by calling sapi_module.get_stat() Fixed#54 (PECL install adds extension= instead of zend_extension= to php.ini) release 7.0.0 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch for https://wiki.php.net/rfc/empty_isset_exprs.