Skip to content

Convert resource to object in Sysvshm extension - #5499

Closed
kocsismate wants to merge 10 commits into
php:masterfrom
kocsismate:sysvshm-resource
Closed

Convert resource to object in Sysvshm extension#5499
kocsismate wants to merge 10 commits into
php:masterfrom
kocsismate:sysvshm-resource

Conversation

@kocsismate

@kocsismatekocsismate commented Apr 30, 2020

Copy link
Copy Markdown
Member

No description provided.

@kocsismate
kocsismate marked this pull request as draft April 30, 2020 09:56
@kocsismate
kocsismateforce-pushed the sysvshm-resource branch 3 times, most recently from a4bd83b to 14ed430CompareApril 30, 2020 11:19
@kocsismate
kocsismate marked this pull request as ready for review April 30, 2020 11:20
@kocsismate
kocsismateforce-pushed the sysvshm-resource branch 2 times, most recently from 72fe90f to 68d63d3CompareMay 1, 2020 17:22
Comment threadext/sysvshm/sysvshm.c Outdated
Comment threadext/sysvshm/sysvshm.c Outdated
Comment threadext/sysvshm/sysvshm.stub.php Outdated
@kocsismate
kocsismateforce-pushed the sysvshm-resource branch 3 times, most recently from f2b4b70 to 3eac56aCompareMay 7, 2020 07:31
@kocsismate
kocsismateforce-pushed the sysvshm-resource branch 4 times, most recently from f0c4085 to 143c535CompareMay 17, 2020 21:17
@kocsismate
kocsismateforce-pushed the sysvshm-resource branch 4 times, most recently from ab91f89 to c33db95CompareJune 11, 2020 07:13
@cmb69

Copy link
Copy Markdown
Member

I just noticed that this overlaps with PR #3235.

Comment threadUPGRADING Outdated
Comment threadext/sysvshm/sysvshm.c Outdated
Comment threadext/sysvshm/tests/003.phpt Outdated
@kocsismate

kocsismate commented Jun 16, 2020

Copy link
Copy Markdown
MemberAuthor

@cmb69 Thanks for the heads up! Unfortunately, I didn't notice this before. However, I think Michał's PR is quite much outdated.

Though, should we get inspiration from his work, and use SysvSharedMemoryBlock (or SysvSharedMemorySegment) instead of SysvSharedMemory?

@cmb69cmb69 mentioned this pull request Jun 16, 2020
@brzuchal

Copy link
Copy Markdown
Contributor

@cmb69 my PR is way outdated. AFAIR it took me a while to figure out proper naming of classes and functions so feel free to reuse them.

Comment threadext/sysvshm/sysvshm.c Outdated
Comment threadext/sysvshm/sysvshm.c Outdated
Comment threadext/sysvshm/sysvshm.c Outdated
Comment threadext/sysvshm/sysvshm.c Outdated
@kocsismate
kocsismate deleted the sysvshm-resource branch June 16, 2020 14:39
@brzuchal

Copy link
Copy Markdown
Contributor

I didn't take a deserved look to the patch to agree with closing my outdated PR enough. What you propose here is just a replacement for a resource and delivers an object with no behaviour - IMO that doesn't make sense to bring a class with no behaviour if we can! most of read-write functions could be added to the OOP API on introduced class.

@kocsismate

kocsismate commented Jun 16, 2020

Copy link
Copy Markdown
MemberAuthor

didn't take a deserved look to the patch to agree with closing my outdated PR enough.

Then sorry for the premature close, and feel free to reopen it if you desire to.

I hope my previous reply (#3235 (comment)) clears your doubts. I think it makes sense to separate these changes. Especially, because the migration by using an "opaque" object didn't need any RFC (or at least comments of a wider audience), while a new API does.

@brzuchal

Copy link
Copy Markdown
Contributor

@kocsismate no worries. I'll take advantage of proposing similar API on a fresh PR soon.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@kocsismate@cmb69@brzuchal@nikic@Girgias@carusogabriel