Uh oh!
There was an error while loading. Please reload this page.
Convert resource to object in Sysvshm extension - #5499
Conversation
a4bd83b to
14ed430Compare72fe90f to
68d63d3CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f2b4b70 to
3eac56aComparef0c4085 to
143c535Compareab91f89 to
c33db95Comparecmb69
commented
Jun 16, 2020
I just noticed that this overlaps with PR #3235. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fix Unknown default value & promote a warning to exception
c33db95 to
9ac2790Compare@cmb69 Thanks for the heads up! Unfortunately, I didn't notice this before. However, I think Michał's PR is quite much outdated. Though, should we get inspiration from his work, and use |
brzuchal
commented
Jun 16, 2020
@cmb69 my PR is way outdated. AFAIR it took me a while to figure out proper naming of classes and functions so feel free to reuse them. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
brzuchal
commented
Jun 16, 2020
I didn't take a deserved look to the patch to agree with closing my outdated PR enough. What you propose here is just a replacement for a |
Then sorry for the premature close, and feel free to reopen it if you desire to. I hope my previous reply (#3235 (comment)) clears your doubts. I think it makes sense to separate these changes. Especially, because the migration by using an "opaque" object didn't need any RFC (or at least comments of a wider audience), while a new API does. |
brzuchal
commented
Jun 16, 2020
@kocsismate no worries. I'll take advantage of proposing similar API on a fresh PR soon. |
No description provided.