Refactored some ZPP calls in OCI8.

[jensdenies]

Thanks to the comments of @kocsismate on #5701 i refactored some ZPP calls to the "zend_parse_method_parameters" variant, which ensures ZPP is always called on method/function invocation.

I also moved the "old_oci_close_semantics" check beneath the ZPP check.

[kocsismate]

Thanks for your work! All in all, the PR looks good to me as-is. I only had a few small nits, but I'm not 100% sure it's worth to address them right now. So let's now wait for other reviews.

[kocsismate]

These consecutive checks everywhere could be optimized a tiny little bit by either:

• using else if clauses
• extracting getThis() in an outer condition so that this function is not called multiple times

However, all the ZEND_NUM_ARGS() == ... checks indicate that the default value handling is not right - which is something we want to fix later. That's why I'm also ok with leaving these conditions as you have them currently.

[kocsismate]

ping @cjbj

[cjbj]

If the tests pass, LGTM

[carusogabriel]

Do we have oci8 enabled in our CIs?

[kocsismate]

@carusogabriel Nope. :( I believe Jens run the tests locally. @jensdenies, so the tests pass, right?

[cjbj]

Traditionally only gcov ran Oracle DB. But I guess http://gcov.php.net/ is obsolete?

[nikic]

@cjbj Yes, gcov is no longer used. To test oci, we'd need to have it on either Travis, Azure Pipelines or AppVeyor. It does look like installing it on travis is possible: https://github.com/Vincit/travis-oracledb-xe No idea how compatible that is with licensing.

[nikic]

I've opened php/php-tasks#5 to track testing oci8 on CI, though from a cursory look, it doesn't look like a simple thing right now.