ext/standard warning to error promotions

[Girgias]

Does should be rather uncontroversial I think

[kocsismate]

array_key_exists() is not a good target for this. Please see Nikita's comment here: #4887

[Girgias]

isset does a usual int silent type cast, string array keys are the only weird thing where "03" will remain "03" but "3" would become the integer index 3 thus I think the behaviour would be consistent but can double check

[kocsismate]

what about cannot be longer than %d characters? As far as I see the condition, less than MAXFQDNLEN isn't true, because being equal is also okay.

[kocsismate]

Suggested change

	zend_argument_value_error(2, "must be between 1 and 65535 when Argument #5 ($raw) is true");
	zend_argument_value_error(2, "must be between 1 and 65535 when argument #5 ($raw) is true");

[Girgias]

I dropped the array_key_exist one while addressing the reviews

[nikic]

I don't think we should list all possibilities here, as this may get extended and depends on environment (e.g. I don't think CAA works on Windows). Just say valid DNS record type or something like that.

[nikic]

I'd only mention DNS_* here (we do this in a few places).

[nikic]

I'd go for is too large here, the exact value doesn't add value as it's impossible to reach with sensible code.

[nikic]

These should be %d. Though I'm not really sure if we actually want to promote these. The number differs by platform and is something one could hit with reasonable code. As gethostbyname() is already fallible, it would currently be a necessary false check.

[nikic]

We should just ZEND_ASSERT(fdat) here.

[Girgias]

So compared to gethostbynamel(), gethostbyname() does not return false should I change this to return false if I revert the ValueError to warning?