Notice and Warning promotion in ext/zip

[Girgias]

IMHO Most of these notices should have been warnings already as similar error states to those were warnings in other extensions, therefore I also promoted them to ValueErrors

[remicollet]

Sorry but I don't like this one, especially the php_zip_parse_options part.

In previous versions, we don't have any notice/warning

And I don't think we should be stricter than function arg parsing, so only raise exception in strict mode.

[Girgias]

Sorry but I don't like this one, especially the php_zip_parse_options part.

In previous versions, we don't have any notice/warning

Are these notices/warnings new in PHP 8?

And I don't think we should be stricter than function arg parsing, so only raise exception in strict mode.

I'm not sure what you mean by this? PHP 8 will throw type errors even for internal functions and not return null + warning.

[remicollet]

I mean that

<?php
function run(bool $b) {
echo "$b" ? "Yes\n" : "No\n";
}
run(1);

run without any error.

[remicollet]

it is where I say we have no waning in previous version.

[Girgias]

Okay, I see now, so if I drop the changes in php_zip_parse_options() would it be more acceptable?

[remicollet]

I'm mostly fine with TypeError, but only in strict mode.

I will read other change after the week-end.

[nikic]

Is there any precedent for this? I don't remember us making strict_types distinctions for something other than parameters anywhere.

[nikic]

Apart from php_zip_parse_options() this looks pretty good to me. For php_zip_parse_options() I would suggest not to mess with strict_types (which I think we don't do anywhere else) and only add the warnings. The warnings can be converted to errors at a later time then.

[nikic]

This looks good to me, but maybe @remicollet wants to take another look as well.

[remicollet]

Sorry, but I don't see any benefit changing this, and it will make merge from lower version harded and risky.

[remicollet]

please remove all these TODO.
unrelate to this PR
And returning FALSE is the documented behavior for not found entry.

[remicollet]

Thanks,

Squashed and merged

72383cc