Gmp warning to error

[Girgias]

This gets rids of most false returns.

[Girgias]

@kocsismate can you have a look at some of the error messages in here?

[Girgias]

Are there other issues/objections to this? Or can I merge this before FF gets tagged on Tuesday?

[nikic]

Love the signature changes :)

[nikic]

Is it actually necessary to return failure on exception here? I think if we throw, this should still be success, otherwise we're going to try calling do_operation on the second operand again.

[Girgias]

I forgot to drop this again but the DO_BINARY_UI_OP_EX macro does exactly that:

#defineDO_BINARY_UI_OP_EX(op, uop, check_b_zero) \
gmp_zval_binary_ui_op( \
result, op1, op2, op, uop, check_b_zero \
); \
if (UNEXPECTED(EG(exception))) { return FAILURE; } \
return SUCCESS;

[nikic]

Shouldn't this function just accept int instead? Makes little sense to convert to GMP first and then convert back to integer.

[Girgias]

Well the function should be able to accept a GMP object, but it's true that this code makes little sense atm.