Skip to content

Convert resources to objects in ext/sockets - #5900

Closed
kocsismate wants to merge 8 commits into
php:masterfrom
kocsismate:resource-sockets
Closed

Convert resources to objects in ext/sockets#5900
kocsismate wants to merge 8 commits into
php:masterfrom
kocsismate:resource-sockets

Conversation

@kocsismate

@kocsismatekocsismate commented Jul 27, 2020

Copy link
Copy Markdown
Member

No description provided.

@kocsismate
kocsismate marked this pull request as draft July 27, 2020 22:55
@GirgiasGirgias mentioned this pull request Jul 27, 2020
Open
41 tasks
@Girgias

Girgias commented Jul 28, 2020

Copy link
Copy Markdown
Member

Compile error:

/home/vsts/work/1/s/ext/sockets/sockets.c:937:14: error: unused variable ‘php_sock’ [-Werror=unused-variable]
937 | php_socket *php_sock;
| ^~~~~~~~

nikic
nikic reviewed Jul 29, 2020
View reviewed changes
Comment threadext/sockets/sockets.c Outdated
Comment threadext/sockets/sockets.c Outdated
@kocsismatekocsismate added this to the PHP 8.0 milestone Jul 30, 2020
@kocsismate
kocsismate marked this pull request as ready for review August 2, 2020 20:49
nikic
nikic reviewed Aug 2, 2020
View reviewed changes
Comment threadext/sockets/sockets.c Outdated
kocsismate
kocsismate commented Aug 2, 2020
View reviewed changes
Comment threadext/sockets/sockets.c Outdated
Comment threadext/sockets/tests/socket_export_stream-1.phpt Outdated
@kocsismate
kocsismate deleted the resource-sockets branch August 3, 2020 21:30
@jrfnljrfnl mentioned this pull request Aug 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebibwoebibwoebi left review comments
+1 more reviewer
@nikicnikicnikic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PHP 8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kocsismate@Girgias@nikic@bwoebi