Uh oh!
There was an error while loading. Please reload this page.
Promote warnings to Error in FileInfo extension - #5914
Closed
Girgias wants to merge 2 commits into
Closed
Conversation
Member
There was a problem hiding this comment.
I think this code path can't be reached since you added the type error
Member
There was a problem hiding this comment.
I think this message is good as-is, although probably the order of the types could be swapped. As far as I saw, object, array are both displayed before strings, so maybe it's worth to do the same with resources too.
Girgiasforce-pushed
the
fileinfo-warning-to-error
branch
from
July 31, 2020 18:56
05d03fb to
0b54e61CompareGirgias
commented
Aug 1, 2020
MemberAuthor
CI Failure is unrelated |
nikic
approved these changes
Aug 6, 2020
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how we deal with resource types in union?
@kocsismate as the expert here on error messages, what do you recommend?