Skip to content

Convert FTP connection resource to an opaque object - #5945

Closed
sgolemon wants to merge 1 commit into
php:masterfrom
sgolemon:sgolemon.conversion.ftp
Closed

Convert FTP connection resource to an opaque object#5945
sgolemon wants to merge 1 commit into
php:masterfrom
sgolemon:sgolemon.conversion.ftp

Conversation

@sgolemon

@sgolemonsgolemon commented Aug 5, 2020

Copy link
Copy Markdown
Member

No description provided.

@sgolemon

sgolemon commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

Parking this here as part of php/php-tasks#6

kocsismate
kocsismate reviewed Aug 5, 2020
View reviewed changes
Comment threadext/ftp/php_ftp.c Outdated
Comment threadext/ftp/php_ftp.c Outdated
@sgolemon
sgolemonforce-pushed the sgolemon.conversion.ftp branch 2 times, most recently from 3724367 to 6dadf6dCompareAugust 5, 2020 20:37
cmb69
cmb69 reviewed Aug 5, 2020
View reviewed changes
Comment threadext/ftp/php_ftp.c Outdated
kocsismate
kocsismate reviewed Aug 5, 2020
View reviewed changes
Comment threadext/ftp/ftp.stub.php Outdated
@GirgiasGirgias mentioned this pull request Aug 5, 2020
Open
41 tasks
@sgolemon
sgolemonforce-pushed the sgolemon.conversion.ftp branch 3 times, most recently from 94031c1 to ec1e27fCompareAugust 6, 2020 12:54
nikic
nikic reviewed Aug 6, 2020
View reviewed changes
Comment threadext/ftp/php_ftp.c Outdated
@sgolemon
sgolemonforce-pushed the sgolemon.conversion.ftp branch from ec1e27f to 3d103ddCompareAugust 6, 2020 13:29
@nikic

nikic commented Aug 7, 2020

Copy link
Copy Markdown
Member

The failure on Travis looks legitimate.

@sgolemon

sgolemon commented Aug 7, 2020

Copy link
Copy Markdown
MemberAuthor

The failure on Travis looks legitimate.

Legit, but slightly unrelated. I noticed this while writing the test and should have done something about it (and will do now that it's in my way).

The test server that's spawned out in another process is also producing output under happy-path conditions which is able to interleave with the actual test's output in a non-deterministic ways.

I'll look for (or add) a silencer for it.

@sgolemon
sgolemonforce-pushed the sgolemon.conversion.ftp branch from 3d103dd to d5e8d48CompareAugust 7, 2020 15:39
@sgolemon

sgolemon commented Aug 7, 2020

Copy link
Copy Markdown
MemberAuthor

The reason it was noisy is that our mock server doesn't like a disconnect without auth. Silly test servers.

@carusogabrielcarusogabriel added this to the PHP 8.0 milestone Aug 12, 2020
@kocsismatekocsismate modified the milestones: PHP 8.0, PHP 8.1Aug 12, 2020
@sgolemon

sgolemon commented Oct 21, 2020

Copy link
Copy Markdown
MemberAuthor

Merged as b4503fb

Ayesh added a commit to Ayesh/php-src that referenced this pull request May 8, 2021
@Ayesh
Move FTP extension class FTPConnection to FTP\Connection
e6a66c5
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`.
This also adds an entry to `./UPGRADING` file.
Related: php#6925, php#5945
@AyeshAyesh mentioned this pull request May 8, 2021
Merged
nikic pushed a commit that referenced this pull request May 8, 2021
@Ayesh@nikic
Move FTP extension class FTPConnection to FTP\Connection
68224f2
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`.
This also adds an entry to `./UPGRADING` file.
Related: #6925, #5945
@AyeshAyesh mentioned this pull request May 8, 2021
Merged
Ayesh added a commit to Ayesh/php-src that referenced this pull request May 8, 2021
@Ayesh
[LDAP] Move resource-object classes of LDAP to \LDAP namespaces
56402ee
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions).
Related: php#6925, php#5945, php#6960
nikic pushed a commit that referenced this pull request May 9, 2021
@Ayesh
Move resource-object classes of LDAP to\LDAPnamespaces (#6963)
e0b947a
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions).
Related: #6925, #5945, #6960
@jrfnljrfnl mentioned this pull request Aug 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69cmb69cmb69 left review comments
@kocsismatekocsismatekocsismate left review comments
+1 more reviewer
@nikicnikicnikic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PHP 8.1

Development

Successfully merging this pull request may close these issues.

5 participants

@sgolemon@nikic@cmb69@kocsismate@carusogabriel